This revision was automatically updated to reflect the committed changes.
Closed by commit rL323181: Prevent unaligned memory read in parseMinidumpString
(authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D42348?vs=
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
LGTM. Did you run the testsuite? If it's clean, feel free to merge.
https://reviews.llvm.org/D42348
___
lldb-commits mailing list
lldb-commits@li
teemperor added a reviewer: davide.
teemperor added a comment.
Thanks, I think only this and the first GoParser patch (
https://reviews.llvm.org/D42339 ) needs some double checking, the others (
https://reviews.llvm.org/D42346, https://reviews.llvm.org/D42338 ) are trivial
and I'll merge in the
davide added a comment.
I'll be happy to review all your patch set tomorrow, Raphael. Do you mind to
add me as reviewer so I don't lose track of your work?
https://reviews.llvm.org/D42348
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
teemperor created this revision.
teemperor added reviewers: dvlahovski, zturner.
It's possible to hit an unaligned memory read when reading `source_length` as
the `data` array is only aligned with 2 bytes (it's actually a UTF16 array).
This patch memcpy's `source_length` into a local variable to
