davide added a comment.
LGTM. FWIW, if people are not maintaining the `Go` and the `Java` plugin we
should consider removing them entirely.
It's a huge amount of code and if there are no users/developers, it's really
not worth the trouble.
Repository:
rL LLVM
https://reviews.llvm.org/D42339
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323119: Fix uninitialized variable in GoParser (authored by
teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D42339?vs=130779&id=1308
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
lgtm (the go plugin is kinda unmaintained now...)
https://reviews.llvm.org/D42339
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http:
teemperor created this revision.
teemperor added a reviewer: ribrdb.
teemperor edited the summary of this revision.
`m_last_tok` isn't initialized anywhere before it's used the first time (most
likely in the `GoParser::Rule::error` method), which causes most of the
GoParser tests to fail with sa