labath added a comment.
Committed as r322190. I've changed one more std::function to function_ref and
re-clang-formatted the patch.
Repository:
rL LLVM
https://reviews.llvm.org/D41745
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
This revision was automatically updated to reflect the committed changes.
Closed by commit rL322190: Handle O reply packets during qRcmd (authored by
labath, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D41745?vs=128991&id=129273#toc
owenpshaw added a comment.
Thanks! I don't have commit access, so someone needs to commit this for me,
right?
https://reviews.llvm.org/D41745
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D41745#970362, @owenpshaw wrote:
> Updated patch with new function name suggested by @clayborg. Added unit test
> and changed to llvm::function_ref as sugges
owenpshaw updated this revision to Diff 128991.
owenpshaw added a comment.
Updated patch with new function name suggested by @clayborg. Added unit test
and changed to llvm::function_ref as suggested by @labath.
Based on Greg's comments in the other thread, I've kept the new function
separate,
labath added a comment.
The ProcessGdbRemote part is not really testable in it's current form, but for
the rest, you should be able to write a gdbremoteclient unittest (see
unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp).
Comment at: source/Plugins/Process/
owenpshaw created this revision.
owenpshaw added a reviewer: clayborg.
Gdb servers like openocd may send many $O reply packets for the client to
output during a qRcmd command sequence. Currently, lldb interprets the first O
packet as an unexpected response. Besides generating no output, this c
