zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
This looks better. Technically it's possible to break this with some weird
PDBs but I don't think it's possible to do better without using the native
reader.
Repository:
rL LLVM
https:
asmith updated this revision to Diff 127658.
asmith added a comment.
If a `Symbols` table is present then lldb can retrieve symbols for the types
listed in PDBSym_Type. In other words, if we want symbolic information for a
function then checking for the `Symbols` table is sufficient.
Repositor
asmith added inline comments.
Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:127
+ }
+ lldbassert(m_session_up.get());
+ if (auto enum_tables_up = m_session_up->getEnumTables()) {
clayborg wrote:
> I am assuming this assert won't fire if we give t
zturner added inline comments.
Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:108-125
+ if (auto module_sp = m_obj_file->GetModule()) {
+// See if a symbol file was specified through the `--symfile` option.
+FileSpec symfile = module_sp->GetSymbo
clayborg added inline comments.
Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:127
+ }
+ lldbassert(m_session_up.get());
+ if (auto enum_tables_up = m_session_up->getEnumTables()) {
I am assuming this assert won't fire if we give this an ELF or Ma
asmith created this revision.
1. Finding symbols through --symfile
2. More abilities: Functions, Blocks, GlobalVariables, LocalVariables,
VariableTypes
Repository:
rL LLVM
https://reviews.llvm.org/D41092
Files:
source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
unittests/SymbolFile/PDB/Sym
