This revision was automatically updated to reflect the committed changes.
Closed by commit rL319504: Add lldb-test. (authored by zturner).
Changed prior to commit:
https://reviews.llvm.org/D40636?vs=124960&id=125052#toc
Repository:
rL LLVM
https://reviews.llvm.org/D40636
Files:
lldb/trunk
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
This LGTM. I think we can iterate in tree from what we have.
https://reviews.llvm.org/D40636
___
lldb-commits mailing list
lldb-commits@lists.llv
zturner updated this revision to Diff 124960.
zturner added a comment.
Updated based on labath@'s suggestions. Also added a new class `LinePrinter`,
shamelessly ripped and stripped down from a copy used in one of LLVM's dumpers,
but that makes it possible to do some nice formatting easily.
ht
You’re right that it’s basically reimplementing readobj but as you said, we
have our own object file readers. More importantly though, even if we
delegated to llvm, something could still in theory go wrong in the Module
class.
Plus, the important thing part of this patch is not this one module
com
labath added a comment.
I feel this is reimplementing llvm-readobj, but maybe that's appropriate as we
are reimplementing object file readers as well (my original patch wouldn't be
necessary if we were using the llvm object library). Minor comments below, but
I actually quite like this approach
zturner created this revision.
Herald added subscribers: krytarowski, mgorny, srhines.
This is basically a proof-of-concept and starting point for having a
testing-centric tool in LLDB. I'm sure this leaves a lot of room to be
desired, but this at least allows us to have something to build on.
