jankratochvil marked 2 inline comments as done.
jankratochvil added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h:487
+ public:
+// C++14: Use heterogenous lookup.
+DWZCommonFile(const lldb_private::FileSpec &filespec_ref);
--
jankratochvil added a comment.
Going to update the patch.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h:92
// C++14: mutable std::shared_timed_mutex m_dwz_uniq_mutex;
mutable std::recursive_mutex m_dwz_uniq_mutex;
labath wrote:
> Is `llvm
labath added a comment.
I am only commenting on the c++14 stuff. I think all of the things you need
here are available to us already through various llvm utilities. See inline
comments for details.
For the "meat" of this patchset, I think clayborg is the only one who can do a
proper review of
jankratochvil created this revision.
Herald added subscribers: JDevlieghere, mgorny.
This is the kitchen sink. It also covers separate DWZ common files.
All DWZ patches are also applied in: git clone -b dwz
git://git.jankratochvil.net/lldb
https://reviews.llvm.org/D40474
Files:
include/lld
