bsdjhb added inline comments.
Comment at: source/Plugins/Process/elf-core/elf-core-enums.h:14
+/// Core files PT_NOTE segment descriptor types
+enum {
+ NT_PRSTATUS = 1,
krytarowski wrote:
> labath wrote:
> > krytarowski wrote:
> > > alexandreyy wrote:
> > > > k
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318399: Implement core dump debugging for PPC64le (authored
by labath).
Changed prior to commit:
https://reviews.llvm.org/D39681?vs=123151&id=123166#toc
Repository:
rL LLVM
https://reviews.llvm.org/
alexandreyy added a comment.
In https://reviews.llvm.org/D39681#925864, @labath wrote:
> Also, I have trouble downloading the core file from phabricator. Alexandre,
> can you sent them to me directly?
Sent the test files by e-mail.
Thanks.
https://reviews.llvm.org/D39681
_
alexandreyy updated this revision to Diff 123151.
alexandreyy added a comment.
Herald added a subscriber: JDevlieghere.
Removed enums without namespaces.
https://reviews.llvm.org/D39681
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py
packages/Pyt
krytarowski added inline comments.
Comment at: source/Plugins/Process/elf-core/elf-core-enums.h:14
+/// Core files PT_NOTE segment descriptor types
+enum {
+ NT_PRSTATUS = 1,
labath wrote:
> krytarowski wrote:
> > alexandreyy wrote:
> > > krytarowski wrote:
> >
labath added a comment.
Also, I have trouble downloading the core file from phabricator. Alexandre, can
you sent them to me directly?
https://reviews.llvm.org/D39681
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cg
labath added inline comments.
Comment at: source/Plugins/Process/elf-core/elf-core-enums.h:14
+/// Core files PT_NOTE segment descriptor types
+enum {
+ NT_PRSTATUS = 1,
krytarowski wrote:
> alexandreyy wrote:
> > krytarowski wrote:
> > > alexandreyy wrote:
> >
krytarowski added inline comments.
Comment at: source/Plugins/Process/elf-core/elf-core-enums.h:14
+/// Core files PT_NOTE segment descriptor types
+enum {
+ NT_PRSTATUS = 1,
alexandreyy wrote:
> krytarowski wrote:
> > alexandreyy wrote:
> > > krytarowski wrote:
alexandreyy added inline comments.
Comment at: source/Plugins/Process/elf-core/elf-core-enums.h:14
+/// Core files PT_NOTE segment descriptor types
+enum {
+ NT_PRSTATUS = 1,
krytarowski wrote:
> alexandreyy wrote:
> > krytarowski wrote:
> > > No namespace here?
krytarowski added inline comments.
Comment at: source/Plugins/Process/elf-core/elf-core-enums.h:14
+/// Core files PT_NOTE segment descriptor types
+enum {
+ NT_PRSTATUS = 1,
alexandreyy wrote:
> krytarowski wrote:
> > No namespace here?
> I think these constant
alexandreyy added inline comments.
Comment at: source/Plugins/Process/elf-core/elf-core-enums.h:14
+/// Core files PT_NOTE segment descriptor types
+enum {
+ NT_PRSTATUS = 1,
krytarowski wrote:
> No namespace here?
I think these constants are used for multiple O
krytarowski added inline comments.
Comment at: source/Plugins/Process/elf-core/elf-core-enums.h:14
+/// Core files PT_NOTE segment descriptor types
+enum {
+ NT_PRSTATUS = 1,
No namespace here?
https://reviews.llvm.org/D39681
___
alexandreyy updated this revision to Diff 122879.
alexandreyy added a comment.
Removed issue note from commit message.
https://reviews.llvm.org/D39681
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py
packages/Python/lldbsuite/test/functionalities/
alexandreyy added a comment.
In https://reviews.llvm.org/D39681#920349, @labath wrote:
> I'm not sure what's the problem with backtracing without more info, but the
> nice thing about core files is that you can open a ppc and x86 one side by
> side and see how for do you get before things start
alexandreyy updated this revision to Diff 122872.
alexandreyy added a comment.
Fixed backtrace issue.
https://reviews.llvm.org/D39681
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py
packages/Python/lldbsuite/test/functionalities/postmortem/elf-co
alexandreyy added a comment.
In https://reviews.llvm.org/D39681#921620, @labath wrote:
> Looks good, thank you. Just please make sure you change the file name at top
> of the new header file and add inclusion guards.
Done. Could you commit it?
I don't have commit access.
https://reviews.llvm
alexandreyy updated this revision to Diff 122423.
alexandreyy added a comment.
Added inclusion guards in elf-core-enums.h
https://reviews.llvm.org/D39681
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py
packages/Python/lldbsuite/test/functionaliti
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks good, thank you. Just please make sure you change the file name at top of
the new header file and add inclusion guards.
Comment at: source/Plugins/Process/elf-core/elf
alexandreyy updated this revision to Diff 122276.
alexandreyy added a comment.
Fixed test identation
https://reviews.llvm.org/D39681
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py
packages/Python/lldbsuite/test/functionalities/postmortem/elf-cor
alexandreyy updated this revision to Diff 122265.
alexandreyy added a comment.
Changed namespaces in core enums.
https://reviews.llvm.org/D39681
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py
packages/Python/lldbsuite/test/functionalities/postmo
labath added a comment.
Thank you. I've just noticed a couple of details we should address.
Comment at: source/Plugins/Process/elf-core/elf-core-enums.h:1
+//===-- ProcessElfCore.cpp --*- C++
-*-===//
+//
Please update the f
alexandreyy added a comment.
In https://reviews.llvm.org/D39681#920349, @labath wrote:
> I'm not sure what's the problem with backtracing without more info, but the
> nice thing about core files is that you can open a ppc and x86 one side by
> side and see how for do you get before things start
alexandreyy updated this revision to Diff 122239.
alexandreyy marked an inline comment as done.
alexandreyy added a comment.
Moved core enums to header file.
https://reviews.llvm.org/D39681
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py
packages
labath added a comment.
I'm not sure what's the problem with backtracing without more info, but the
nice thing about core files is that you can open a ppc and x86 one side by side
and see how for do you get before things start to diverge. The interesting
commands you can start with are "image l
alexandreyy added a comment.
Thanks for all the reviews @labath and @clayborg.
I changed the code to use the DenseMap and added the files for testing.
The backtrace is not working properly yet,
It is showing all frames, just the current.
Am I missing something?
https://reviews.llvm.org/D39681
alexandreyy updated this revision to Diff 14.
alexandreyy added a comment.
Update according to reviews.
https://reviews.llvm.org/D39681
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py
packages/Python/lldbsuite/test/functionalities/postmortem/
clayborg added inline comments.
Comment at: source/Plugins/Process/elf-core/ThreadElfCore.h:183
lldb_private::DataExtractor m_vregset_data;
+ lldb_private::DataExtractor m_vsregset_data; /* For PPC VSX registers. */
labath wrote:
> gpregset and fpregset sou
labath added a comment.
We were quite successful in the past in creating tiny core files to test these
register contexts. Could you take a look at
`test/testcases/functionalities/postmortem/elf-core/make-core.sh` to see if you
can do the same for your architecture?
Comment a
alexandreyy created this revision.
Herald added subscribers: kbarton, mgorny, nemanjai.
Implement core dump debugging for PPC64le.
https://reviews.llvm.org/D39681
Files:
source/Plugins/Process/Utility/CMakeLists.txt
source/Plugins/Process/Utility/RegisterContextPOSIX_ppc64le.cpp
source/Pl
29 matches
Mail list logo
