[Lldb-commits] [PATCH] D38328: Assume git-generated patch files in build scripts

2017-09-28 Thread Francis Ricci via Phabricator via lldb-commits
fjricci added a comment. Oh I see from the discussion on https://github.com/apple/swift-lldb/pull/252 that it was accidental - don't worry about it Repository: rL LLVM https://reviews.llvm.org/D38328 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [PATCH] D38328: Assume git-generated patch files in build scripts

2017-09-28 Thread Francis Ricci via Phabricator via lldb-commits
fjricci added a comment. @jasonmolenda - just an FYI that I'm an llvm committer (I contribute frequently to compiler-rt, and used to contribute quite a bit to lldb as well). No worries about this patch though, especially given how small it is. Repository: rL LLVM https://reviews.llvm.org/D3

[Lldb-commits] [PATCH] D38328: Assume git-generated patch files in build scripts

2017-09-27 Thread Phabricator via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL314366: Change build-llvm.py and build-lldb-llvm-clang's patching mechanisms to (authored by jmolenda). Repository: rL LLVM https://reviews.llvm.org/D38328 Files: lldb/trunk/scripts/Xcode/build-llvm

[Lldb-commits] [PATCH] D38328: Assume git-generated patch files in build scripts

2017-09-27 Thread Francis Ricci via Phabricator via lldb-commits
fjricci created this revision. It is probably reasonable to expect that most (or all) users of the patch file feature will be using git, and assuming git patch files makes this feature easier to use. https://reviews.llvm.org/D38328 Files: scripts/Xcode/build-llvm.py scripts/build-lldb-llvm-