[Lldb-commits] [PATCH] D36496: Fix VASprintfTest.cpp for Darwin, add checks

2017-08-09 Thread Tim Hammerquist via Phabricator via lldb-commits
penryu added a comment. Committed revision 310499. Closing revision https://reviews.llvm.org/D36496 'Fix VASprintfTest.cpp for Darwin, add checks'... https://reviews.llvm.org/D36496 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://l

[Lldb-commits] [PATCH] D36496: Fix VASprintfTest.cpp for Darwin, add checks

2017-08-08 Thread Tim Hammerquist via Phabricator via lldb-commits
penryu added a comment. I'd prototyped this as simply prepending "DISABLED_" for non-Windows, but as this was designed as a temporary measure, I decided to ensure the same behavior was tested on Windows, and similar/equivalent behavior tested on other platforms. https://reviews.llvm.org/D3649

[Lldb-commits] [PATCH] D36496: Fix VASprintfTest.cpp for Darwin, add checks

2017-08-08 Thread Tim Hammerquist via Phabricator via lldb-commits
penryu created this revision. The EncodingError test ensures that trying to encode a multibyte wchar with a given codepage fails. If setlocale() fails, the encoding is performed using the current locale, which may or may not fail. This patch asserts that both setlocale() operations are successful