This revision was automatically updated to reflect the committed changes.
Closed by commit rL317411: Improve the posix core file triple detection
(authored by tberghammer).
Repository:
rL LLVM
https://reviews.llvm.org/D36046
Files:
lldb/trunk/source/Core/ArchSpec.cpp
lldb/trunk/source/Plu
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine. Sorry for the delay.
https://reviews.llvm.org/D36046
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.
tberghammer added a comment.
Hi Greg, can you take a look sometime? Thanks, Tamas
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:733-735
+ if (target_arch.IsMIPS()) {
return target_arch;
+ }
nitesh.jain wrote:
> tberghammer wrote:
> > Hi
tberghammer updated this revision to Diff 111326.
tberghammer added a comment.
Add comment about the MIPS special case.
https://reviews.llvm.org/D36046
Files:
source/Core/ArchSpec.cpp
source/Plugins/Process/elf-core/ProcessElfCore.cpp
Index: source/Plugins/Process/elf-core/ProcessElfCore.
nitesh.jain added inline comments.
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:733-735
+ if (target_arch.IsMIPS()) {
return target_arch;
+ }
tberghammer wrote:
> Hi Nitesh,
>
> I tried to remove this MIPS specific code as it shouldn't b
tberghammer added inline comments.
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:733-735
+ if (target_arch.IsMIPS()) {
return target_arch;
+ }
Hi Nitesh,
I tried to remove this MIPS specific code as it shouldn't be necessary if I add
the
tberghammer created this revision.
Herald added subscribers: kristof.beyls, arichardson, sdardis, aemerson.
Posix core files sometime don't contain enough information to correctly
detect the OS. If that is the case we should use the OS from the target
instead as it will contain usable information
