[Lldb-commits] [PATCH] D35615: Add data formatter for libc++ std::tuple

2017-11-01 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL317095: Add data formatter for libc++ std::tuple (authored by labath). Repository: rL LLVM https://reviews.llvm.org/D35615 Files: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-form

[Lldb-commits] [PATCH] D35615: Add data formatter for libc++ std::tuple

2017-11-01 Thread Pavel Labath via Phabricator via lldb-commits
labath updated this revision to Diff 121131. labath added a comment. s/nullptr/ValueObjectSP() https://reviews.llvm.org/D35615 Files: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/tuple/Makefile packages/Python/lldbsuite/test/functionalities/data-

[Lldb-commits] [PATCH] D35615: Add data formatter for libc++ std::tuple

2017-11-01 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. There wasn't a strong reason for using nullptr, I can convert those to ValueObjectSP(). Given that this was your only objection to this patch, I'm going to assume it is ok to land after this. https://reviews.llvm.org/D35615 __

[Lldb-commits] [PATCH] D35615: Add data formatter for libc++ std::tuple

2017-10-31 Thread Jim Ingham via Phabricator via lldb-commits
jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. It seems awkward to me to be returning empty ValueObjectSP's by returning nullptr and then relying on conversion. We don't do it that way in most of the other formatters. If ther

[Lldb-commits] [PATCH] D35615: Add data formatter for libc++ std::tuple

2017-07-19 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. Herald added subscribers: mgorny, srhines. Herald added a reviewer: EricWF. https://reviews.llvm.org/D35615 Files: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/tuple/Makefile packages/Python/lldbsuite/test/functionalit