jessicah updated this revision to Diff 107623.
jessicah added a comment.
A test case was added.
https://reviews.llvm.org/D35525
Files:
packages/Python/lldbsuite/test/help/TestHelp.py
source/Interpreter/CommandInterpreter.cpp
Index: source/Interpreter/CommandInterpreter.cpp
===
clayborg added a comment.
Add a test for this and this will be good to go.
https://reviews.llvm.org/D35525
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jingham added a comment.
BTW, the second listing was after applying your patch, showing it clearly does
the right thing...
https://reviews.llvm.org/D35525
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
jingham added a comment.
Yes, your version clearly has the test right. I was wondering why this didn't
have a more dramatic ill-effect, but it turns out that this function is only
used for printing argument help text, which it clearly messes up:
(lldb) help format
--
jessicah added reviewers: jingham, clayborg.
jessicah added a comment.
Add Jim and Greg per Zachary's suggestion.
Jessica
https://reviews.llvm.org/D35525
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
I am OOO for another week, can you add jingham or clayborg instead?
On Thu, Jul 20, 2017 at 11:40 AM Jessica Han via Phabricator <
revi...@reviews.llvm.org> wrote:
> jessicah added reviewers: tfiala, zturner.
> jessicah added a comment.
>
> Todd, Zachary,
>
> Can you help review this change?
>
> T
jessicah added reviewers: tfiala, zturner.
jessicah added a comment.
Todd, Zachary,
Can you help review this change?
Thanks,
Jessica
https://reviews.llvm.org/D35525
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cg
