This revision was automatically updated to reflect the committed changes.
labath marked an inline comment as done.
Closed by commit rL322171: [zorg] Enable assertions on the linux lldb bot
(authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https:/
labath marked an inline comment as done.
labath added a comment.
I am sorry about the delay, I was on extended leave.
Comment at: zorg/buildbot/builders/LLDBBuilder.py:921
scriptExt='.sh',
+ extra_cmake_args=[],
labath updated this revision to Diff 122063.
labath added a comment.
Avoid mutable arguments
https://reviews.llvm.org/D35356
Files:
buildbot/osuosl/master/config/builders.py
zorg/buildbot/builders/LLDBBuilder.py
Index: zorg/buildbot/builders/LLDBBuilder.py
gkistanova added a comment.
Hi Pavel,
The patch looks Ok, with a small issue to address before committing.
Comment at: zorg/buildbot/builders/LLDBBuilder.py:921
scriptExt='.sh',
+ extra_cmake_args=[],
):
---
labath created this revision.
This adds support for the extra_cmake_args argument to the
LLDBScriptCommandsFactory and uses that to enable assertions on the
linux bot.
While I'm in there, I also remove the "update ndk" step -- it was a bad
idea because it's introducing android-specific code into
