[Lldb-commits] [PATCH] D35123: Remove shared pointer from NativeProcessProtocol

2017-07-18 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL308282: Remove shared pointer from NativeProcessProtocol (authored by labath). Changed prior to commit: https://reviews.llvm.org/D35123?vs=105637&id=107034#toc Repository: rL LLVM https://reviews.ll

[Lldb-commits] [PATCH] D35123: Remove shared pointer from NativeProcessProtocol

2017-07-10 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added a comment. I have no particular opinion on it. If it builds and works, I'm fine with it. https://reviews.llvm.org/D35123 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [PATCH] D35123: Remove shared pointer from NativeProcessProtocol

2017-07-07 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. The usage of shared_from_this forces us to separate construction and initialization phases, because shared_from_this() is not available in the constructor (or destructor). The shared semantics are not necessary, as we always have a clear owner of the native process cl