This revision was automatically updated to reflect the committed changes.
Closed by commit rL306682: Move Timer and TraceOptions from Core to Utility
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D34746?vs=104624&id=104647#toc
Repository:
rL LLVM
https://reviews.ll
Cool, lgtm
On Thu, Jun 29, 2017 at 5:52 AM Pavel Labath via Phabricator <
revi...@reviews.llvm.org> wrote:
> labath updated this revision to Diff 104624.
> labath added a comment.
>
> That's a good idea. This time I almost smuggled in a (unused) Host include
> into
> Utility -- it was a leftover f
labath updated this revision to Diff 104624.
labath added a comment.
That's a good idea. This time I almost smuggled in a (unused) Host include into
Utility -- it was a leftover from the Host::ThreadLocalStorage times. I'll make
sure to run it in the future.
After fixing that issue, I see no diff
zturner added a comment.
Can you do a diff before and after of the analyze-deps script output? I don't
imagine it will make a difference, but I've been surprised by it before. In
general you should do it before and after every patch of this nature.
https://reviews.llvm.org/D34746
labath created this revision.
Herald added subscribers: mgorny, emaste.
The classes have no dependencies, and they are used both by lldb and
lldb-server, so it makes sense for them to live in the lowest layers.
https://reviews.llvm.org/D34746
Files:
include/lldb/Core/Timer.h
include/lldb/Co
