This revision was automatically updated to reflect the committed changes.
Closed by commit rL306397: Add debug_frame section support (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D34613?vs=103922&id=104134#toc
Repository:
rL LLVM
https://reviews.llvm.org/D34613
Fil
labath added inline comments.
Comment at: include/lldb/Symbol/DWARFCallFrameInfo.h:38
DWARFCallFrameInfo(ObjectFile &objfile, lldb::SectionSP §ion,
lldb::RegisterKind reg_kind, bool is_eh_frame);
clayborg wrote:
> labath wrote:
> > clay
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
If the CIEs can change per CIE,l then this patch is fine.
Comment at: include/lldb/Symbol/DWARFCallFrameInfo.h:38
DWARFCallFrameInfo(ObjectFile &objfile, lldb::Section
labath added a comment.
In https://reviews.llvm.org/D34613#790745, @clayborg wrote:
> Glad this is happening. Does this mean we won't see the "bad eh frame"
> warnings anymore on linux? See inlined comments.
Unfortunately, I doubt it. This does nothing about eh_frame parsing, it just
adds deb
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Glad this is happening. Does this mean we won't see the "bad eh frame" warnings
anymore on linux? See inlined comments.
Comment at: include/lldb/Symbol/DWARFCa
tatyana-krasnukha added a comment.
Works well for me. Thank you a lot for bringing it up to scratch!
https://reviews.llvm.org/D34613
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
labath created this revision.
Herald added subscribers: aprantl, mgorny.
This is a beefed-up version of https://reviews.llvm.org/D33504, which adds
support for dwarf 4
debug_frame section format.
The main difference here is that the decision whether to use eh_frame or
debug_frame is done on a pe
