This revision was automatically updated to reflect the committed changes.
Closed by commit rL306391: Move Connection and IOObject interfaces to Utility
module (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D34400?vs=103971&id=104125#toc
Repository:
rL LLVM
https://r
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Nice, yea this will be a big help I think.
https://reviews.llvm.org/D34400
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lis
labath updated this revision to Diff 103971.
labath added a comment.
This is how things would look like if we move Connection to Utility instead. I
needed to do two things to make this happen:
- Keep Connection::CreateDefaultConnection in Host (now known as
Host::CreateDefaultConnection), becaus
On 20 June 2017 at 16:47, Zachary Turner wrote:
> I do think at some point we will need to break up Host, but whether the best
> way is to move stuff into Utility or to somewhere else is an open question.
> Host also depends on Target, Symbol, process plugins, and various other
> things. So we wil
I do think at some point we will need to break up Host, but whether the
best way is to move stuff into Utility or to somewhere else is an open
question. Host also depends on Target, Symbol, process plugins, and various
other things. So we will need a way to group together all the stuff in Host
that
On 20 June 2017 at 14:28, Zachary Turner wrote:
> I had actually been considering going the other way. Moving connection and
> all implementations to Utility. Host is a big contributor to the dependency
> problems, so putting more stuff in seems like the wrong direction.
Well, I'd say that Core i
I had actually been considering going the other way. Moving connection and
all implementations to Utility. Host is a big contributor to the dependency
problems, so putting more stuff in seems like the wrong direction.
The end state i had in mind was similar to llvm support (which is more less
the
labath created this revision.
Herald added a subscriber: mgorny.
All implementations of the connection interface live in the Host module
already, so it makes sense for the interface itself to be defined there.
https://reviews.llvm.org/D34400
Files:
include/lldb/Core/Connection.h
include/lld
