nitesh.jain added a comment.
Hi Ki,
The changes has been committed (https://reviews.llvm.org/rL301537).
Thanks
Repository:
rL LLVM
https://reviews.llvm.org/D32340
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/c
nitesh.jain added inline comments.
Comment at:
lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/control/TestMiExec.py:329
+# We need to get past these instructions with a step to reach call
to s_MyFunction.
+self.runCmd("-exec-step --thread 1")
ki.stfu added inline comments.
Comment at:
lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/control/TestMiExec.py:329
+# We need to get past these instructions with a step to reach call
to s_MyFunction.
+self.runCmd("-exec-step --thread 1")
This revision was automatically updated to reflect the committed changes.
Closed by commit rL301530: [LLDB][MIPS] Fix TestMiExec.py failure. (authored by
nitesh.jain).
Changed prior to commit:
https://reviews.llvm.org/D32340?vs=96368&id=96890#toc
Repository:
rL LLVM
https://reviews.llvm.org
nitesh.jain marked an inline comment as done.
nitesh.jain added a comment.
In https://reviews.llvm.org/D32340#733387, @ki.stfu wrote:
> Thanks for catching this! Could you update this CL to let me commit it?
Yes , Please commit it.
https://reviews.llvm.org/D32340
__
nitesh.jain updated this revision to Diff 96368.
nitesh.jain added a comment.
Update diff as per suggestion.
https://reviews.llvm.org/D32340
Files:
packages/Python/lldbsuite/test/tools/lldb-mi/control/TestMiExec.py
Index: packages/Python/lldbsuite/test/tools/lldb-mi/control/TestMiExec.py
==
ki.stfu requested changes to this revision.
ki.stfu added a comment.
This revision now requires changes to proceed.
Thanks for catching this! Could you update this CL to let me commit it?
Comment at:
packages/Python/lldbsuite/test/tools/lldb-mi/control/TestMiExec.py:287-289
+
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
sounds reasonable
https://reviews.llvm.org/D32340
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
nitesh.jain created this revision.
Herald added subscribers: arichardson, ki.stfu.
Call to s_MyFunction may not follow immediately after g_MyFunction. There might
be some instructions in between to restore caller-saved registers. We need to
get past these instructions with a step to reach call t
