[Lldb-commits] [PATCH] D30454: [LLDB][MIPS] Fix typo in MatchesModuleSpec()

clayborg added a comment. How does VSDO get loaded when debugging a normal process? In the core file case you probably need to create the VSDO module from memory by locating it somehow and add it to the target before the dynamic loader goes looking for it. Wouldn't that fix the issue? https:/

[Lldb-commits] [PATCH] D30454: [LLDB][MIPS] Fix typo in MatchesModuleSpec()

labath added a comment. The VDSO is a pretty standard shared library in most aspects -- it contains the implementations of a couple of functions whose implementation can depend on the specific hardware revision (the fastest way to make a syscall, the fastest way to obtain system time, etc.). Th

[Lldb-commits] [PATCH] D30454: [LLDB][MIPS] Fix typo in MatchesModuleSpec()

nitesh.jain added a comment. In https://reviews.llvm.org/D30454#693614, @clayborg wrote: > So a ModuleSpec allows you to specify a module by path, UUID and many other > things. This is falling down for a magic file that doesn't actually exist > right? Yes. > "vsdo" is just a made up name

[Lldb-commits] [PATCH] D30454: [LLDB][MIPS] Fix typo in MatchesModuleSpec()

clayborg added a comment. So a ModuleSpec allows you to specify a module by path, UUID and many other things. This is falling down for a magic file that doesn't actually exist right? "vsdo" is just a made up name for the table of loaded shared libraries? Is that correct? I need to understand wh

[Lldb-commits] [PATCH] D30454: [LLDB][MIPS] Fix typo in MatchesModuleSpec()

nitesh.jain added a comment. Attach log file F3122646: module.log https://reviews.llvm.org/D30454 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [PATCH] D30454: [LLDB][MIPS] Fix typo in MatchesModuleSpec()

nitesh.jain added a comment. The issue was observed while parsing "vdso module" for the core file. When the DynamicLoader::LoadModuleAtAddress is called to load "vdso" module. Since "vdso" doesn't match with any of the module in the target.GetImages(), the check_alternative_file_name becomes tr

[Lldb-commits] [PATCH] D30454: [LLDB][MIPS] Fix typo in MatchesModuleSpec()

clayborg added a comment. Object name is used for a module spec where the file is "/tmp/foo.a" and the object name is "bar.o". So this is for named objects within a container file like a BSD archive. If there is no object name, it doesn't need to be matched. If there is an object name, then the

[Lldb-commits] [PATCH] D30454: [LLDB][MIPS] Fix typo in MatchesModuleSpec()

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. This logic is wrong. If there is no object name, true should be returned. The old logic is correct. https://reviews.llvm.org/D30454 __

[Lldb-commits] [PATCH] D30454: [LLDB][MIPS] Fix typo in MatchesModuleSpec()

labath added a comment. I am not sure this is correct... looking at the other checks in this function, they seem to be following the same pattern... could you explain where you ran into this? https://reviews.llvm.org/D30454 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D30454: [LLDB][MIPS] Fix typo in MatchesModuleSpec()

nitesh.jain created this revision. The MatchesModuleSpec() should return false if module_ref is not found. https://reviews.llvm.org/D30454 Files: source/Core/Module.cpp Index: source/Core/Module.cpp === --- source/Core/Module.c