This revision was automatically updated to reflect the committed changes.
Closed by commit rL291895: Remove a couple of Stream flags (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D28616?vs=84143&id=84267#toc
Repository:
rL LLVM
https://reviews.llvm.org/D28616
Files
jingham added a comment.
Yeah, I'm starting to remember this a bit. For some reason, we have individual
log channels with verbose as a category (LIBLLDB_LOG_VERBOSE,
POSIX_LOG_VERBOSE, KDP_LOG_VERBOSE) and we have LLDB_LOG_OPTION_VERBOSE which
is set "GetVerbose" is testing for.
So you can d
labath added a comment.
In https://reviews.llvm.org/D28616#644287, @jingham wrote:
> Is this going to make passing LIBLLDB_LOG_OPTION_VERBOSE to
> GetLogIfAllCategoriesSet into a "you can't see these logs" operation?
>
> I use this in a couple places where I have detailed information that I
>
jingham added a comment.
Is this going to make passing LIBLLDB_LOG_OPTION_VERBOSE to
GetLogIfAllCategoriesSet into a "you can't see these logs" operation?
I use this in a couple places where I have detailed information that I usually
don't want to see, but in some odd cases I might need it. Lo
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Most of the DWARF stuff is about to go away anyway in favor of using the LLVM
DWARF parser as I am currently modifying it to support all we need in LLDB so
we can get rid of the entire DWA
labath created this revision.
labath added reviewers: clayborg, zturner.
labath added subscribers: lldb-commits, beanz.
Herald added a subscriber: aprantl.
I came across this while trying to understand what Log::Debug does. It turns out
it does not do anything, as there is no instance of someone s
