This revision was automatically updated to reflect the committed changes.
Closed by commit rL287864: Introduce chrono to more gdb-remote functions
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D26971?vs=79050&id=79203#toc
Repository:
rL LLVM
https://reviews.llvm.or
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Much better, looks good.
https://reviews.llvm.org/D26971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-
labath updated this revision to Diff 79050.
labath added a comment.
Changes since last version:
- Rename the class to Timeout<>, to reflect the fact that I'd like to use it as
a general method for describing timeouts.
- add "using namespace std::chrono" to files with significat chrono usage.
I
labath updated this revision to Diff 78895.
labath added a comment.
A new version, which uses a helper class which enables all the implicit
conversions that one would normally expect from the duration classes.
Things left TBD:
- name
- where to put it
- whether inheriting from Optional is fine (
labath added a comment.
In https://reviews.llvm.org/D26971#602738, @clayborg wrote:
> It would be nice if we can find a way to be able to use any time units we
> want when specifying the timeout. I would rather not have everyone have to
> convert their times to microseconds. Maybe we just add s
labath added inline comments.
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp:56
-response,
-
std::chrono::duration_cast(kInterruptTimeout)
-.count(),
zturner wrote:
> I think we should all be willing to agree tha
labath added a comment.
I suppose we could create a new class (I am not sure what a good name for that
would be... `OptionalDuration`, which inherits from `llvm:Optional`, but
provides the additional conversion operator to make things work seamlessly.
Something like:
template
class Optiona
zturner added inline comments.
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp:56
-response,
-
std::chrono::duration_cast(kInterruptTimeout)
-.count(),
I think we should all be willing to agree that `using namespa
zturner added a comment.
In https://reviews.llvm.org/D26971#602738, @clayborg wrote:
> It would be nice if we can find a way to be able to use any time units we
> want when specifying the timeout. I would rather not have everyone have to
> convert their times to microseconds. Maybe we just add
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
It would be nice if we can find a way to be able to use any time units we want
when specifying the timeout. I would rather not have everyone have to convert
their times to micros
labath created this revision.
labath added reviewers: clayborg, zturner, jingham.
labath added a subscriber: lldb-commits.
This replaces the usage of raw integers with duration classes in the gdb-remote
packet management functions. The values are still converted back to integers
once
they go into
11 matches
Mail list logo
