This revision was automatically updated to reflect the committed changes.
Closed by commit rL286352: Disable windows-only minidump plugin (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D26393?vs=77175&id=77325#toc
Repository:
rL LLVM
https://reviews.llvm.org/D26393
labath added a comment.
Yeah, feel free to take over. I was not planning to do any more work here -
just wanted to wrap things up. I am going to commit this then, and leave the
rest to you.
https://reviews.llvm.org/D26393
___
lldb-commits mailing
amccarth accepted this revision.
amccarth added a comment.
This revision is now accepted and ready to land.
Problem was at my end. This patch works fine for me now.
I'm planning to do some more minidump work, so I'd be happy to take over with
eliminating the old Windows-specific implementation.
amccarth added a comment.
In https://reviews.llvm.org/D26393#589421, @labath wrote:
> In https://reviews.llvm.org/D26393#589363, @amccarth wrote:
>
> > I started testing the new plugin on Windows yesterday, and it doesn't work
> > (all the tests fail). I'm planning to debug today, and, once I g
labath added a comment.
In https://reviews.llvm.org/D26393#589363, @amccarth wrote:
> I started testing the new plugin on Windows yesterday, and it doesn't work
> (all the tests fail). I'm planning to debug today, and, once I get it
> working, I'd be happy to switch it over.
Interesting. It
amccarth added a comment.
I started testing the new plugin on Windows yesterday, and it doesn't work (all
the tests fail). I'm planning to debug today, and, once I get it working, I'd
be happy to switch it over.
https://reviews.llvm.org/D26393
__
labath created this revision.
labath added reviewers: amccarth, zturner.
labath added subscribers: lldb-commits, dvlahovski.
This commit disables the windows-only minidump plugin and enables the new
cross-platform plugin for windows minidump files. Test decorators are adjusted
to
reflect that: wi
