This revision was automatically updated to reflect the committed changes.
Closed by commit rL287916: Merge Linux and FreeBSD arm64 register contexts
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D25947?vs=75718&id=79286#toc
Repository:
rL LLVM
https://reviews.llvm.
labath added a comment.
Thank you for trying this out, and getting the core file. Unfortunately, the
core is somewhat bigger then I had hoped for (it contains a very large data
segment). I'll try to play around with this on a freebsd vm to see if I can
reduce that somehow (maybe another ulimit
emaste added a comment.
In https://reviews.llvm.org/D25947#597160, @labath wrote:
> Ed, if I may suggest, while you are playing with the arm machine, could you
> grab us a core file or two? It'd be great to be able to do a basic sanity
> check on these things without physical access.
I used m
emaste added a comment.
The tests are not in great shape on FreeBSD/arm64 today, but look roughly
equivalent with and without this patch.
At https://reviews.llvm.org/rL287887:
===
Test Result Summary
===
Test Methods: 1148
Reruns: 16
labath added a comment.
Ed, have you had a chance to try this out? I'd like to put this in soon.
https://reviews.llvm.org/D25947
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a comment.
Yes, I'd like to do similar refactorings to other contexts as well.
I'll wait until next week so Ed can give this a shot -- I am busy with other
stuff these days anyway.
Ed, if I may suggest, while you are playing with the arm machine, could you
grab us a core file or t
emaste added a comment.
> Ed, what do you think about this one? Is there anyone with a FreeBSD arm64
> setup that could verify this?
We have an arm64 reference machine in the FreeBSD cluster and I will test after
I return from travel later this week, although perhaps @andrew can try it
before
sas accepted this revision.
sas added a reviewer: sas.
sas added a comment.
Cool stuff.
Are you planning on doing a similar change for other architectures?
https://reviews.llvm.org/D25947
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good as long as all register contexts are the same between these targets.
https://reviews.llvm.org/D25947
___
lldb-commits mailing list
labath added a comment.
Ed, what do you think about this one? Is there anyone with a FreeBSD arm64
setup that could verify this?
https://reviews.llvm.org/D25947
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
labath updated this revision to Diff 75718.
labath added a comment.
clang-format the patch
https://reviews.llvm.org/D25947
Files:
source/Plugins/Process/FreeBSD/FreeBSDThread.cpp
source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp
source/Plugins/Process/Utility/CMakeLists.tx
labath created this revision.
labath added reviewers: emaste, clayborg.
labath added subscribers: lldb-commits, dmikulin.
Herald added subscribers: modocache, mgorny, beanz, rengolin, aemerson.
This is a test-the-water change about possibilities of reducing duplication in
the register context defi
12 matches
Mail list logo
