This revision was automatically updated to reflect the committed changes.
Closed by commit rL285356: [CMake] Rename lldb-launcher to darwin-debug
(authored by cbieneman).
Changed prior to commit:
https://reviews.llvm.org/D25745?vs=75507&id=76121#toc
Repository:
rL LLVM
https://reviews.llvm.
beanz updated this revision to Diff 75507.
beanz added a comment.
Cleaning up extra references to lldb-launcher
https://reviews.llvm.org/D25745
Files:
scripts/Python/finish-swig-Python-LLDB.sh
scripts/Python/finishSwigPythonLLDB.py
tools/darwin-debug/CMakeLists.txt
Index: tools/darwin-d
labath accepted this revision.
labath added a reviewer: labath.
labath added a comment.
I have no idea what this executable does, but I am pretty sure we don't use it.
PS: there are some mentions of this in the
`scripts/Python/finishSwigPythonLLDB.py` script. Does that need an update?
https://
tfiala accepted this revision.
tfiala added a subscriber: labath.
tfiala added a comment.
This revision is now accepted and ready to land.
This seems fine, but @labath might want to weigh in if Android tools have a
hard-baked assumption anywhere on lldb-launcher.
https://reviews.llvm.org/D25745
beanz created this revision.
beanz added reviewers: tfiala, zturner.
beanz added a subscriber: lldb-commits.
Herald added a subscriber: mgorny.
This tool is only built on Darwin, and the name darwin-debug matches the Xcode
project. We should have this in sync unless there is a good reason not to.
