abhishek.aggarwal closed this revision.
abhishek.aggarwal added a comment.
Already merged it in LLDb repo. So closing this revision.
https://reviews.llvm.org/D24251
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-
abhishek.aggarwal updated this revision to Diff 70677.
abhishek.aggarwal added a comment.
Removed get() for shared_ptr
https://reviews.llvm.org/D24251
Files:
include/lldb/API/SBSection.h
scripts/interface/SBSection.i
source/API/SBSection.cpp
Index: source/API/SBSection.cpp
==
Eugene.Zelenko added inline comments.
Comment at: source/API/SBSection.cpp:257
@@ +256,3 @@
+SectionSP section_sp(GetSP());
+if (section_sp.get())
+return section_sp->GetPermissions();
You don't need to use get(), because smart pointers have
http:
abhishek.aggarwal updated this revision to Diff 70513.
abhishek.aggarwal added a comment.
Changes based on review
- Added header doc and ran clang-format on code
https://reviews.llvm.org/D24251
Files:
include/lldb/API/SBSection.h
scripts/interface/SBSection.i
source/API/SBSection.cpp
In
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Please rebase code on trunk and run Clang-format.
https://reviews.llvm.org/D24251
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Just add header doc and this is good to go.
Comment at: include/lldb/API/SBSection.h:74
@@ -73,1 +73,3 @@
+uint32_t
+GetPermissions () const;
-
