This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rG30ff4b485147: Fix lldb build on Mac. (authored by labath).
Herald added a project: LLDB.
Changed prior to commit:
https:
Ahh right, in that case I can commit it in the morning unless someone else
beats me to it.
On Tue, Aug 30, 2016 at 6:55 PM Taras Tsugrii wrote:
> Thanks for the review Zachary, but I don’t have commit privileges, so I
> hope that someone can commit the change for me.
>
>
>
> *From: *Zachary Turn
Thanks for the review Zachary, but I don’t have commit privileges, so I hope
that someone can commit the change for me.
From: Zachary Turner
Date: Tuesday, August 30, 2016 at 6:52 PM
To: "reviews+d24064+public+13175c1cba5ef...@reviews.llvm.org"
, Taras Tsugrii
Cc: "lldb-commits@lists.llvm.org
Looks good, feel free to commit without review when you're fixing a build
On Tue, Aug 30, 2016 at 4:57 PM Taras Tsugrii wrote:
> wttsugrii created this revision.
> wttsugrii added a reviewer: zturner.
> wttsugrii added a subscriber: lldb-commits.
>
>
> https://github.com/llvm-mirror/lldb/commit/e
wttsugrii created this revision.
wttsugrii added a reviewer: zturner.
wttsugrii added a subscriber: lldb-commits.
https://github.com/llvm-mirror/lldb/commit/e80f43fd78fa0fbc04d2d59b5713acb5d06c8308
greatly improved an API, but missed one more occurence of legacy usage.
This leads to:
if (extrac
