This revision was automatically updated to reflect the committed changes.
Closed by commit rL277140: Add/fix support for i386 elf core files (authored by
dvlahovski).
Changed prior to commit:
https://reviews.llvm.org/D22917?vs=65957&id=66114#toc
Repository:
rL LLVM
https://reviews.llvm.org/
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
thanks
https://reviews.llvm.org/D22917
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/l
dvlahovski updated this revision to Diff 65957.
dvlahovski added a comment.
Checking for null pointer, in case of a corrupt core file
https://reviews.llvm.org/D22917
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/TestLinuxCore.py
source/Plugins/ObjectFile/ELF/O
labath added a comment.
Looks great, thanks.
Please just fix the null pointer issue and we are good to go.
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1506
@@ -1502,2 +1505,3 @@
{
llvm::StringRef path(data.GetCStr(&offset));
dvlahovski created this revision.
dvlahovski added a reviewer: labath.
dvlahovski added a subscriber: lldb-commits.
There were places in the code, assuming(hardcoding) offsets
and types that were only valid for the x86_64 elf core file format.
The NT_PRSTATUS and NT_PRPSINFO structures are with t
