compnerd closed this revision.
compnerd added a comment.
SVN r277011
https://reviews.llvm.org/D20436
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
compnerd added a subscriber: sas.
compnerd added a comment.
@emaste I think so. I was hoping that @zturner or @sas would be able to get a
windows run. However, Linux and FreeBSD should give us some assurance that
this is good. How about I go ahead and commit this tomorrow?
https://reviews.l
emaste added a comment.
Is this ready to be committed?
https://reviews.llvm.org/D20436
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Yeah I can do this today.
> On Jul 19, 2016, at 1:58 AM, Zachary Turner wrote:
>
> I can't test this on Windows until Friday because I'm traveling and my laptop
> isn't set up to build lldb. Could Stephane maybe help?
>
>
> On Tue, Jul 19, 2016 at 1:51 AM Saleem Abdulrasool
> wrote:
> compn
emaste added a comment.
With this patch, test results on FreeBSD are consistent.
https://reviews.llvm.org/D20436
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
emaste added a subscriber: emaste.
emaste added a comment.
I'm testing on FreeBSD now
https://reviews.llvm.org/D20436
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
I can't test this on Windows until Friday because I'm traveling and my
laptop isn't set up to build lldb. Could Stephane maybe help?
On Tue, Jul 19, 2016 at 1:51 AM Saleem Abdulrasool
wrote:
> compnerd updated this revision to Diff 64448.
>
> https://reviews.llvm.org/D20436
>
> Files:
> inclu
compnerd added a comment.
Tested against Linux-x86_64, tests state seems unchanged across the patch.
@zturner you want to run another round on Windows before I merge this?
https://reviews.llvm.org/D20436
___
lldb-commits mailing list
lldb-commits@
compnerd added a comment.
Ugh, yeah, I had forgotten about this. Ill try to get to this tonight/tomorrow.
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp:354-355
@@ -358,5 +353,4 @@
{
-// Calculate absolute timeout value
-TimeValue timeout = Ti
compnerd added a comment.
*hadn't
Repository:
rL LLVM
https://reviews.llvm.org/D20436
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
I think will be good idea to try to commit these changes before 3.9 branching.
Repository:
rL LLVM
https://reviews.llvm.org/D20436
___
lldb-commits mailing list
ll
Here is a patch you can apply on top of your patch to fix the compiler and
runtime errors (on Windows at least).
Most of the compiler errors were around the use of duration_cast. I've
never used std::chrono before, but my best guess is that system_time::now()
is a different type on Windows and ot
zturner added a comment.
I'm still getting a lot of crashes after this, but this will at least fix the
compiler errors. I will try to look at the crashes on Monday.
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp:354-355
@@ -358,5 +353,4 @@
{
-//
I can try this on Windows tomorrow
On Thu, May 19, 2016 at 11:04 AM Saleem Abdulrasool
wrote:
> compnerd added a comment.
>
> Yeah, I was thinking that once this clean up is done, we should remove the
> use of TimeValue in favor of std::chrono::duration.
>
>
> Repository:
> rL LLVM
>
> http://r
compnerd added a comment.
Yeah, I was thinking that once this clean up is done, we should remove the use
of TimeValue in favor of std::chrono::duration.
Repository:
rL LLVM
http://reviews.llvm.org/D20436
___
lldb-commits mailing list
lldb-commit
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
We should think about converting everyone over to using
std::chrono::microseconds for any timeout parameters that are currently
"uint32_t timeout_usec". But we can do that in a future chan
16 matches
Mail list logo
