labath abandoned this revision.
labath added a comment.
I am abandoning this in favor of http://reviews.llvm.org/D21324, which achieves
the same result (no Platform plugin), but still uses the elf-parsing method to
keep everything working as is now.
You can give it a try if you want, but I don'
nitesh.jain added inline comments.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:438
@@ +437,3 @@
+// The auxiliary vector consists of a sequence of key-value pairs, where
key and value are of
+// the pointer size for the architecture tha
labath added inline comments.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:438
@@ +437,3 @@
+// The auxiliary vector consists of a sequence of key-value pairs, where
key and value are of
+// the pointer size for the architecture that the
nitesh.jain added inline comments.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:438
@@ +437,3 @@
+// The auxiliary vector consists of a sequence of key-value pairs, where
key and value are of
+// the pointer size for the architecture tha
nitesh.jain added a comment.
I will check it and let you know asap.
Thanks
http://reviews.llvm.org/D20368
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a comment.
@nitesh.jain could you give the new version one more spin. I tried it on the
auxv files you sent me, and it should work, but maybe there are other issues we
did not notice. And thank you again for the help and all the patience.
Everyone else: The new version has only mip
labath updated this revision to Diff 60256.
labath added a comment.
This revision is now accepted and ready to land.
Use an auxv-based approach for detecting the architecture in case of mips.
http://reviews.llvm.org/D20368
Files:
source/Plugins/Process/Linux/NativeProcessLinux.cpp
source/Pl
labath abandoned this revision.
Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp:53
@@ -22,2 +52,3 @@
+
NativeRegisterContextLinux::NativeRegisterContextLinux(NativeThreadProtocol
&native_thread,
uint
nitesh.jain added a comment.
In case of MIPS, ptrace always return 64 bit data irrespetive of Arch.
http://reviews.llvm.org/D20368
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
nitesh.jain added inline comments.
Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp:53
@@ -22,2 +52,3 @@
+
NativeRegisterContextLinux::NativeRegisterContextLinux(NativeThreadProtocol
&native_thread,
u
labath planned changes to this revision.
Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp:53
@@ -22,2 +52,3 @@
+
NativeRegisterContextLinux::NativeRegisterContextLinux(NativeThreadProtocol
&native_thread,
jaydeep added a comment.
Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp:53
@@ -22,2 +52,3 @@
+
NativeRegisterContextLinux::NativeRegisterContextLinux(NativeThreadProtocol
&native_thread,
uint32_t
omjavaid accepted this revision.
omjavaid added a comment.
Seems to be causing no regressions on arm-linux.
http://reviews.llvm.org/D20368
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
labath added inline comments.
Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp:39
@@ +38,3 @@
+int regset = NT_PRSTATUS;
+Error error = NativeProcessLinux::PtraceWrapper(PTRACE_GETREGSET, tid,
®set, &ioVec, sizeof_native_regs_struct);
+HostInfo:
labath added inline comments.
Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp:39
@@ +38,3 @@
+int regset = NT_PRSTATUS;
+Error error = NativeProcessLinux::PtraceWrapper(PTRACE_GETREGSET, tid,
®set, &ioVec, sizeof_native_regs_struct);
+HostInfo:
nitesh.jain added inline comments.
Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp:39
@@ +38,3 @@
+int regset = NT_PRSTATUS;
+Error error = NativeProcessLinux::PtraceWrapper(PTRACE_GETREGSET, tid,
®set, &ioVec, sizeof_native_regs_struct);
+Host
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good with 1 minor comment inline. Feel free to ignore/postpone it if you
want
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:2072-2073
@@ -21
nitesh.jain added a comment.
Let me check and get back to you.
Thanks.
http://reviews.llvm.org/D20368
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
uweigand added a comment.
This patch builds and works fine on s390x-linux.
http://reviews.llvm.org/D20368
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a comment.
@nitesh.jain: I have checked that this compiles, but I could not verify the
functionality for lack of hardware. Could you give this a spin? I am
particularly interested in the "debugging 32 bit process with a 64 bit server"
use case as that is most likely to break. If it
labath created this revision.
labath added reviewers: tberghammer, omjavaid, nitesh.jain, uweigand.
labath added a subscriber: lldb-commits.
Herald added a subscriber: aemerson.
this removes the last usage of the Platform plugin in NPL. It was being used
for determining the
architecture of a runn
21 matches
Mail list logo
