Re: [Lldb-commits] [PATCH] D20351: second pass over removal of Mutex and Condition

2016-05-18 Thread Saleem Abdulrasool via lldb-commits
compnerd closed this revision. compnerd marked an inline comment as done. compnerd added a comment. SVN r270024. Repository: rL LLVM http://reviews.llvm.org/D20351 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cg

Re: [Lldb-commits] [PATCH] D20351: second pass over removal of Mutex and Condition

2016-05-18 Thread Saleem Abdulrasool via lldb-commits
compnerd marked 2 inline comments as done. Comment at: source/Interpreter/CommandObject.cpp:339 @@ -338,3 +338,3 @@ m_exe_ctx.Clear(); -m_api_locker.Unlock(); +m_api_locker.unlock(); } zturner wrote: > ``` > if (m_api_locker) > m_api_locker.unloc

Re: [Lldb-commits] [PATCH] D20351: second pass over removal of Mutex and Condition

2016-05-18 Thread Zachary Turner via lldb-commits
zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. Looks good on Windows with the two suggested fixes. Comment at: source/Interpreter/CommandObject.cpp:339 @@ -338,3 +338,3 @@ m_exe_ctx.Clear(); -m_api_locker.Unlock