This revision was automatically updated to reflect the committed changes.
Closed by commit rL269205: Generalize child process monitoring functions
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D20106?vs=56903&id=56932#toc
Repository:
rL LLVM
http://reviews.llvm.org/
krytarowski added a comment.
I'm going to test NetBSD.
http://reviews.llvm.org/D20106
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath updated this revision to Diff 56903.
labath marked 3 inline comments as done.
labath added a comment.
Herald added a subscriber: emaste.
Remove the typedef and add changes to windows, osx, and freebsd-specific code.
I didn't
try building NetBSD, but given that there is no Plugins/Process/N
labath added a comment.
In http://reviews.llvm.org/D20106#426224, @zturner wrote:
> It's too bad llvm doesn't have an equivalent of boost::any, because that
> would be perfect here :-/
I actually think that a `std::function` is better here than an `any` type
because it ensures type safety (ev
emaste added a comment.
Nice.
For test building FreeBSD, snapshot VM images are available at
ftp://ftp.freebsd.org/pub/FreeBSD/snapshots/VM-IMAGES/11.0-CURRENT/amd64/Latest/
and I have some instructions for building lldb on FreeBSD at
https://wiki.freebsd.org/lldb.
http://reviews.llvm.org/D2
It's too bad llvm doesn't have an equivalent of boost::any, because that
would be perfect here :-/
On Tue, May 10, 2016 at 12:39 PM Greg Clayton wrote:
> clayborg requested changes to this revision.
> clayborg added a comment.
> This revision now requires changes to proceed.
>
> Just get rid of
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Just get rid of the extra typedef as specified in inline comments and this is
good to go.
Comment at: include/lldb/Host/HostProcess.h:41
@@ -41,1 +40,3 @@
+publ
labath added a comment.
In http://reviews.llvm.org/D20106#425825, @labath wrote:
> I am going to try building this on as many systems as I can get my hands on
> tomorrow, as I am pretty sure I have missed some changes on host-specific
> code. I am posting this here now, to get early feedback an
labath added a comment.
I am going to try building this on as many systems as I can get my hands on
tomorrow, as I am pretty sure I have missed some changes on host-specific code.
I am posting this here now, to get early feedback and some round-trips.
http://reviews.llvm.org/D20106
labath created this revision.
labath added reviewers: clayborg, zturner, emaste, krytarowski.
labath added a subscriber: lldb-commits.
This replaces the C-style "void *" baton of the child process monitoring
functions with a more
C++-like API taking a std::function. The motivation for this was th
10 matches
Mail list logo
