rengolin added a comment.
In http://reviews.llvm.org/D19480#410762, @tberghammer wrote:
> I committed in this change based on the approval from @labath with the
> Android - EABI support (no hard float) to get the LLDB Android ARM buildbots
> green again. If you have any more question comment th
tberghammer added a comment.
I committed in this change based on the approval from @labath with the Android
- EABI support (no hard float) to get the LLDB Android ARM buildbots green
again. If you have any more question comment then please let me know and I am
happy to address them with a separ
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267422: Fix ARM attribute parsing for Android after rL267291
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D19480?vs=54854&id=54864#toc
Repository:
rL LLVM
http://revie
tberghammer updated this revision to Diff 54854.
tberghammer added a comment.
I updated the diff to only address the soft-flat case (Android-EABI). This
fixes the most important case but I would like to fix the hard-flat case as
well in the not so distant future as we have the same problem (regr
srhines added a comment.
In http://reviews.llvm.org/D19480#410664, @tberghammer wrote:
> This patch only effects debugging (all modified file is part of LLDB).
>
> I want to get the Android <-> EABI part fixed ASAP as a recent LLDB change
> completely broke Android ARM debugging with adding ARM.
tberghammer added a comment.
This patch only effects debugging (all modified file is part of LLDB).
I want to get the Android <-> EABI part fixed ASAP as a recent LLDB change
completely broke Android ARM debugging with adding ARM.Attributes support
(causing Environment mismatch between EABI and
srhines added a comment.
In http://reviews.llvm.org/D19480#410641, @rengolin wrote:
> In http://reviews.llvm.org/D19480#410620, @tberghammer wrote:
>
> > Both executables and shared libraries are containing ARM Attributes what
> > contains the information about soft-float vs hard-float. I am not
rengolin added a comment.
In http://reviews.llvm.org/D19480#410620, @tberghammer wrote:
> Both executables and shared libraries are containing ARM Attributes what
> contains the information about soft-float vs hard-float. I am not sure how
> accurate it is as in theory you can link together an
tberghammer added a comment.
Both executables and shared libraries are containing ARM Attributes what
contains the information about soft-float vs hard-float. I am not sure how
accurate it is as in theory you can link together an object file compiled with
soft float with a one compiled with har
rengolin added a comment.
Don't Android libraries output build attributes for ARM? If they do, that's an
easy way to know.
http://reviews.llvm.org/D19480
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Ideally, we'd be able to pick up the fact that we're dealing with an android
shared library just from looking at it, but it seems they don't contain any
information which would identify them a
tberghammer added inline comments.
Comment at: source/Core/ArchSpec.cpp:1017
@@ +1016,3 @@
+// considered to be compatible. This is required as a workaround for
shared libraries compiled
+// for Android without the NOTE section indicating that they are using the
Android
rengolin added inline comments.
Comment at: source/Core/ArchSpec.cpp:1017
@@ +1016,3 @@
+// considered to be compatible. This is required as a workaround for
shared libraries compiled
+// for Android without the NOTE section indicating that they are using the
Android ABI
tberghammer created this revision.
tberghammer added reviewers: labath, compnerd.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer, rengolin, aemerson.
Fix ARM attribute parsing for Android after rL267291
http://reviews.llvm.org/D19480
Files
14 matches
Mail list logo
