This revision was automatically updated to reflect the committed changes.
Closed by commit rL266286: FileSpec: make matching separator-agnostic again
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D19060?vs=53567&id=53680#toc
Repository:
rL LLVM
http://reviews.llvm.o
Ok sounds good
On Wed, Apr 13, 2016 at 9:56 AM Pavel Labath wrote:
> labath added a comment.
>
> In http://reviews.llvm.org/D19060#399915, @zturner wrote:
>
> > Ahh that's unfortunate. I guess the thing to do is make SetFile and
> > SetDirectory. At least by changing the return type we can get t
labath added a comment.
In http://reviews.llvm.org/D19060#399915, @zturner wrote:
> Ahh that's unfortunate. I guess the thing to do is make SetFile and
> SetDirectory. At least by changing the return type we can get the compiler
> to tell us everywhere this is happening. Did you run the test su
Ahh that's unfortunate. I guess the thing to do is make SetFile and
SetDirectory. At least by changing the return type we can get the compiler
to tell us everywhere this is happening. Did you run the test suite on
Windows to make sure this doesnt break anything?
On Wed, Apr 13, 2016 at 8:36 AM Pave
labath added a comment.
It's a bit more complicated than it seems. GetDirectory() returns a reference
into the FileSpec, and a lot of code modifies it through it. Changing that
would require fixups in all of the users, which I'd want to do separately.
But I do agree that this is the best way fo
The expected behavior imo is to normalize before returning in
GetDirectory(). Perhaps you could add a boolean with default value true?
On Wed, Apr 13, 2016 at 8:26 AM Pavel Labath wrote:
> labath created this revision.
> labath added a reviewer: zturner.
> labath added a subscriber: lldb-commits.
labath created this revision.
labath added a reviewer: zturner.
labath added a subscriber: lldb-commits.
In D18689, I removed the call to Normalize() in FileSpec::SetFile, because it
no longer seemed
needed, and it resolved a quirk in the FileSpec API (spec.GetCString() returnes
a path with
back
