sas closed this revision.
sas added a comment.
Committed as r265418.
http://reviews.llvm.org/D18531
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ted added a comment.
Thanks for adding me, Tamas.
It looks like removing the code in the Hexagon Dynamic Loader plugin will have
lldb drill down into ObjectFileElf, and end up doing the same thing - set the
load address of each section of the ELF file. So it should behave the same as
before th
tberghammer added a reviewer: ted.
tberghammer added a comment.
Looks good (I added Ted as a reviewer for hexagon).
http://reviews.llvm.org/D18531
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
The general idea looks good. You'll want to reach out to the Hexagon dynamic
loader author first on any proposed changes there, though.
Thanks!
-Todd
> On Mar 29, 2016, at 11:45 AM, Francis Ricci wrote:
>
> fjricci updated this revision to Diff 51962.
> fjricci added a comment.
>
> Refactor
tfiala added a subscriber: tfiala.
tfiala added a comment.
The general idea looks good. You'll want to reach out to the Hexagon dynamic
loader author first on any proposed changes there, though.
Thanks!
-Todd
http://reviews.llvm.org/D18531
___
ll
fjricci updated this revision to Diff 51962.
fjricci added a comment.
Refactor to remove code duplication
http://reviews.llvm.org/D18531
Files:
include/lldb/Target/DynamicLoader.h
source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp
source/Plugins/DynamicLoader/Hexagon-D
fjricci added a comment.
I see that DynamicLoaderHexagonDYLD also has a LoadModuleAtAddress function,
which seems to be the same as the one in DynamicLoader, except that the member
functions it calls are overloaded, and it is also missing the newly added
ReadFromMemory code.
I think this funct
tberghammer added a comment.
I think it should be fine to make it public as it don't do anything what can
mess up the private state of the DynamicLoader. In general visibility in LLDB
are decided in a bit randomly so usually it is fine to change them if the
implementation looks like it won't br
fjricci added a comment.
That was actually one of the fixes I originally tried. My only concern is that
LoadModuleAtAddress is a protected method in the dynamic loader. If you think
it's fine to change it to public, I'll go ahead and do that.
http://reviews.llvm.org/D18531
_
tberghammer added a comment.
What is your opinion about replacing the ProcessGDBRemote::LoadModuleAtAddress
with the following code:
lldb::ModuleSP
ProcessGDBRemote::LoadModuleAtAddress (const FileSpec &file, lldb::addr_t
base_addr, bool value_is_offset)
{
DynamicLoader* loader = Ge
fjricci created this revision.
fjricci added reviewers: tberghammer, ADodds, tfiala.
fjricci added subscribers: sas, lldb-commits.
The logic to read modules from memory was added to LoadModuleAtAddress
in the dynamic loader, but not in process gdb remote. This means that when
the remote uses svr4
11 matches
Mail list logo
