sas closed this revision.
sas added a comment.
Committed as r264351.
http://reviews.llvm.org/D18228
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
fjricci added a comment.
Friendly ping.
http://reviews.llvm.org/D18228
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
fjricci created this revision.
fjricci added reviewers: clayborg, granata.enrico, Eugene.Zelenko, jingham.
fjricci added subscribers: sas, lldb-commits.
Fixes SBCommandReturnObject::SetImmediateOutputFile() and
SBCommandReturnObject::SetImmediateOutputFile() for files opened
with "a" or "a+" by re
fjricci updated this revision to Diff 51005.
fjricci added a comment.
Always use write flag, even in append mode
http://reviews.llvm.org/D18228
Files:
source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp
Index: source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp
==
fjricci updated this revision to Diff 51113.
fjricci added a comment.
Added unit test for python file api
http://reviews.llvm.org/D18228
Files:
packages/Python/lldbsuite/test/functionalities/command_script_immediate_output/TestCommandScriptImmediateOutput.py
packages/Python/lldbsuite/test
fjricci added a comment.
I want to add this testing to
functionalities/command_script_immediate_output/TestCommandScriptImmediateOutput.py,
since that test is already very basic coverage of the same functionality.
However, it appears that TestCommandScriptImmediateOutput is an expected fail
on
clayborg added a comment.
Just to be clear in the code we should set the write flag and not make any
assumptions. So then the first diff isn't needed and only PythonDataObjects.cpp
needs to change.
http://reviews.llvm.org/D18228
___
lldb-commits m
fjricci added a comment.
So this was definitely a decision that I was debating. But I assume that the
Append flag must imply the Write flag, since you can't open a file for Append
without also opening it for write ("a" and "a+" both include write privileges).
So I figured that having both "Appe
clayborg requested changes to this revision.
This revision now requires changes to proceed.
Comment at: source/Host/common/File.cpp:48
@@ -47,3 +47,3 @@
}
-else if (options & File::eOpenOptionWrite)
+else
{
This change isn't neede
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Looks great, thanks for catching and fixing this. Can we add a test for this so
we don't regress?
http://reviews.llvm.org/D18228
_
fjricci added a comment.
That makes sense. Will do.
http://reviews.llvm.org/D18228
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
11 matches
Mail list logo
