Yea, because of the fact that we must support both syntaxes on both
platforms, LLVM library is out.
The whole motivation for introducing the path syntax is so that windows
paths behave as if on Windows even if on linux
On Wed, Mar 16, 2016 at 6:19 AM Pavel Labath wrote:
> labath added inline com
labath added inline comments.
Comment at: lldb/trunk/unittests/Host/FileSpecTest.cpp:25
@@ +24,3 @@
+EXPECT_STREQ("F:\\bar", fs_windows.GetCString());
+EXPECT_STREQ("F:", fs_windows.GetDirectory().GetCString());
+EXPECT_STREQ("bar", fs_windows.GetFilename().GetCString(
labath added a comment.
Interesting... I didn't run the tests on windows. I was hoping they would run
mostly the same on all platforms. I'll try to give them a spin now...
Repository:
rL LLVM
http://reviews.llvm.org/D18044
___
lldb-commits maili
This actually broke a couple of unit tests on Windows. Did you try running
these tests on Windows?
On Fri, Mar 11, 2016 at 12:49 AM Pavel Labath wrote:
> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL263207: Fix a couple of cornercases in FileSpe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL263207: Fix a couple of cornercases in FileSpec + tests
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D18044?vs=50275&id=50396#toc
Repository:
rL LLVM
http://reviews.llvm.or
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D18044
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
labath added a comment.
Comment at: unittests/Host/FileSpecTest.cpp:57
@@ +56,3 @@
+// We get "F:/bar" instead.
+// EXPECT_STREQ("F:\\bar",
fs_windows_trailing_slash.GetDirectory().GetCString());
+EXPECT_STREQ(".", fs_windows_trailing_slash.GetFilename().GetCString
labath created this revision.
labath added reviewers: clayborg, zturner.
labath added a subscriber: lldb-commits.
This fixes a couple of corner cases in FileSpec, related to AppendPathComponent
and
handling of root directory (/) file spec. I add a bunch of unit tests for the
new behavior.
Summa
