Re: [Lldb-commits] [PATCH] D17848: Add reverse file remapping for breakpoint set

2016-03-04 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL262711: Add reverse file remapping for breakpoint set (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D17848?vs=49732&id=49812#toc Repository: rL LLVM http://reviews.llvm

Re: [Lldb-commits] [PATCH] D17848: Add reverse file remapping for breakpoint set

2016-03-04 Thread Tamas Berghammer via lldb-commits
tberghammer added a comment. It is a good point. I don't think displaying incorrect path for a breakpoint is a big issue so I don't plan to address it now but we should do it at some point. http://reviews.llvm.org/D17848 ___ lldb-commits mailing li

Re: [Lldb-commits] [PATCH] D17848: Add reverse file remapping for breakpoint set

2016-03-03 Thread Jim Ingham via lldb-commits
jingham added a comment. At some point we should deal with the loss of information when we resolve re-mapped paths. For instance, here I set a breakpoint by the moved source location's full path, and that gets remapped to the build location. That's lovely since it makes the breakpoint take, b

Re: [Lldb-commits] [PATCH] D17848: Add reverse file remapping for breakpoint set

2016-03-03 Thread Jim Ingham via lldb-commits
jingham added a subscriber: jingham. jingham added a comment. This looks fine to me. http://reviews.llvm.org/D17848 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D17848: Add reverse file remapping for breakpoint set

2016-03-03 Thread Tamas Berghammer via lldb-commits
tberghammer created this revision. tberghammer added reviewers: labath, clayborg. tberghammer added a subscriber: lldb-commits. Add reverse file remapping for breakpoint set LLDB can remap a source file to a new directory based on the "target.sorce-map" to handle the usecase when the source code