emaste added inline comments.
Comment at:
lldb/trunk/source/Plugins/Process/Utility/RegisterContextNetBSD_x86_64.cpp:308-309
@@ +307,4 @@
+
+static std::vector&
+GetSharedRegisterInfoVector ()
+{
Unused function?
Repository:
rL LLVM
http://reviews.llvm.org/D
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259462: NetBSD: Define initial RegisterContextNetBSD_x86_64
(authored by kamil).
Changed prior to commit:
http://reviews.llvm.org/D16508?vs=46489&id=46610#toc
Repository:
rL LLVM
http://reviews.llvm
krytarowski added a comment.
Thank you very much! You made this patch possible.
Repository:
rL LLVM
http://reviews.llvm.org/D16508
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi
tfiala accepted this revision.
tfiala added a comment.
Seems reasonable to start. If there are issues, they'll show up when lldb
starts using registers. This will get you started, though.
Repository:
rL LLVM
http://reviews.llvm.org/D16508
___
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D16508
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
krytarowski added a comment.
Please review.
I'm still unsure whether `FPR fpr` will be fine.
Repository:
rL LLVM
http://reviews.llvm.org/D16508
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
krytarowski updated this revision to Diff 46489.
krytarowski added a comment.
Revamped version.
Changes:
- change type of registers from int64_t to uint64_t,
- remove unsupported debug x86 registers,
- model UserArea after mcontext_t
Patch building tested.
Repository:
rL LLVM
http://review
tfiala added a comment.
Glad to hear it!
Repository:
rL LLVM
http://reviews.llvm.org/D16508
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski added a comment.
Thank you @clayborg and @tfiala I'm processing your feedback. In case of
further questions I will let you know.
Your answers make the things more clear.
Repository:
rL LLVM
http://reviews.llvm.org/D16508
___
lldb-co
tfiala added a comment.
> What's the correct approach to address it? Mirror modified
> RegisterInfos_x86_64.h in RegisterContextNetBSD_x86_64.cpp and
> removed/altered static_assert?
I think that's worth trying. That will let you have a contiguous, consistent
register set.
Repository:
rL
clayborg added a comment.
In http://reviews.llvm.org/D16508#338046, @krytarowski wrote:
> 1. I was trying to comment out `DBG` registers (as unsupported by NetBSD)
> from `RegisterInfos_x86_64.h` with the following patch:
>
> But I get this assert being triggered:
>
> In file included from
>
krytarowski added a comment.
1. I was trying to comment out `DBG` registers (as unsupported by NetBSD) from
`RegisterInfos_x86_64.h` with the following patch:
diff --git
a/lldb-git/patches/patch-lldb_source_Plugins_Process_Utility_RegisterInfos__x86__64.h
b/lldb-git/patches/patch-lldb_sourc
krytarowski added a comment.
Thank you @clayborg for your notes. I'm planning to submit new version in the
coming days.
Repository:
rL LLVM
http://reviews.llvm.org/D16508
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llv
clayborg added a comment.
This kind of stuff:
struct UserArea {
GPR gpr;
FPR fpr;
DBG dbg;
};
Was done on MacOSX systems because we have thread_get_state() and
thread_set_state() that take a flavor (enumeration) that specifies which
registers we should read
krytarowski added a comment.
It looks like UserArea will need to map this structure:
typedef struct {
__gregset_t __gregs;
__greg_t_mc_tlsbase;
__fpregset_t__fpregs;
} mcontext_t;
- src/sys/arch/amd64/include/mcontext.h
https://github.com/IIJ-Ne
On Sat, Jan 23, 2016 at 04:02:19PM +, Kamil Rytarowski via lldb-commits
wrote:
> Add basic support, i386 version will be added later.
I think you want to keep at least the mc_tlsbase field as well.
Access to __thread variables will need it.
Joerg
_
tfiala added a comment.
In http://reviews.llvm.org/D16508#334452, @krytarowski wrote:
> @tfiala thank you for your verbose and quick feedback. It made the things
> more clear!
My pleasure!
> While I'm processing your reply -- a question, does it matter whether we
> define GPR as signed or un
krytarowski added a comment.
NetBSD currently doesn't support debug registers.
Repository:
rL LLVM
http://reviews.llvm.org/D16508
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
krytarowski added a comment.
@tfiala thank you for your verbose and quick feedback. It made the things more
clear!
While I'm processing your reply -- a question, does it matter whether we define
GPR as signed or unsigned integers? Is it platform specific part too? Should I
change this to `uint
tfiala added a comment.
If all else fails when trying to look up the NetBSD expectations about register
access, you can start with the ptrace interface (man ptrace). It should have
some way for you to ask for some kind of register-file-offset-based value and a
width to retrieve content from th
tfiala added a comment.
The important part is that you look to see what NetBSD exposes register-wise
for a given process. Even though the architecture is the same across several
different versions of this class, it is possible for an OS to tweak the way the
CPU starts up and therefore influenc
tfiala added a comment.
In http://reviews.llvm.org/D16508#334424, @krytarowski wrote:
> I had difficulties with this code, as each platform implements it differently.
This class is one of the parts of the infrastructure needed to access registers
for a given platform. These show up on the LLD
krytarowski added a comment.
I had difficulties with this code, as each platform implements it differently.
What is DBG? What should be there?
What is UserArea? What should be there?
Repository:
rL LLVM
http://reviews.llvm.org/D16508
___
lldb-c
krytarowski created this revision.
krytarowski added reviewers: emaste, joerg, clayborg, tfiala.
krytarowski added a subscriber: lldb-commits.
krytarowski set the repository for this revision to rL LLVM.
Add basic support, i386 version will be added later.
Repository:
rL LLVM
http://reviews.ll
24 matches
Mail list logo
