[Lldb-commits] [PATCH] D159127: [lldb][libc++] Adds chrono data formatters.

Michael137 added a comment. In D159127#4655450 , @aprantl wrote: > @Mordante @Michael137 This seems to fail on older versions of > compiler/libcxx > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-matrix/7247/ You > can probably fix this by

[Lldb-commits] [PATCH] D159127: [lldb][libc++] Adds chrono data formatters.

aprantl added a comment. @Mordante @Michael137 This seems to fail on older versions of compiler/libcxx https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-matrix/7247/ You can probably fix this by just requiring a minimum clang version in the tests Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D159127: [lldb][libc++] Adds chrono data formatters.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e4264ab1e7a: [lldb][libc++] Adds chrono data formatters. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D159127: [lldb][libc++] Adds chrono data formatters.

Mordante added a comment. In D159127#4654774 , @Michael137 wrote: > Was looking at leftover reviews, would be nice to land this Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159127/

[Lldb-commits] [PATCH] D159127: [lldb][libc++] Adds chrono data formatters.

Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land. Was looking at leftover reviews, would be nice to land this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159127/new/ https://reviews.ll

[Lldb-commits] [PATCH] D159127: [lldb][libc++] Adds chrono data formatters.

Mordante updated this revision to Diff 555763. Mordante marked an inline comment as done. Mordante added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159127/new/ https://reviews.llvm.org/D159127 Files: lldb/s

[Lldb-commits] [PATCH] D159127: [lldb][libc++] Adds chrono data formatters.

Mordante marked 4 inline comments as done. Mordante added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:986-993 + "^std::__[[:alnum:]]+::chrono::" + "(((nano)|(micro)|(milli)|())seconds)|" + "(minutes)|" + "(hours)|"

[Lldb-commits] [PATCH] D159127: [lldb][libc++] Adds chrono data formatters.

Mordante added a comment. In D159127#4626311 , @kastiglione wrote: > Thanks for doing this! > > Question to all: Should the summary string include the unit? lldb doesn't > always show the type, so it could help comprehension if the unit is included. >

[Lldb-commits] [PATCH] D159127: [lldb][libc++] Adds chrono data formatters.

kastiglione added a comment. Thanks for doing this! Question to all: Should the summary string include the unit? lldb doesn't always show the type, so it could help comprehension if the unit is included. For example `60s` instead of `60`. Comment at: lldb/source/Plugins/Lang

[Lldb-commits] [PATCH] D159127: [lldb][libc++] Adds chrono data formatters.

aprantl added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:996 + TypeSummaryImplSP(new StringSummaryFormat( + eTypeOptionHideChildren | eTypeOptionHideValue, "${var.__rep_}"))); } Nice! ===

[Lldb-commits] [PATCH] D159127: [lldb][libc++] Adds chrono data formatters.

Mordante created this revision. Mordante added reviewers: Michael137, aprantl. Herald added a project: All. Mordante requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds the data formatters for chrono duration typedefs. Repository: