[Lldb-commits] [PATCH] D157497: feat: Migrate isArch16Bit

bulbazord requested changes to this revision. bulbazord added a comment. In D157497#4592330 , @Pivnoy wrote: > At the moment, the TargetParser architecture is extensible. This complicates > the addition of new architectures, operating systems, and so on.

[Lldb-commits] [PATCH] D157497: feat: Migrate isArch16Bit

nikic requested changes to this revision. nikic added a comment. This revision now requires changes to proceed. Herald added a subscriber: StephenFan. This change looks strictly worse in isolation, the proposal on discourse did not reach consensus, and looking at the diagram in https://discourse

[Lldb-commits] [PATCH] D157497: feat: Migrate isArch16Bit

Pivnoy added a comment. Herald added a subscriber: sunshaoce. @bulbazord @MaskRay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157497/new/ https://reviews.llvm.org/D157497 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D157497: feat: Migrate isArch16Bit

Pivnoy added a comment. At the moment, the TargetParser architecture is extensible. This complicates the addition of new architectures, operating systems, and so on. In the main discussion, it was proposed to redesign the architecture of this module in order to increase the possibility of adding

[Lldb-commits] [PATCH] D157497: feat: Migrate isArch16Bit

bulbazord added a comment. In D157497#4586165 , @MaskRay wrote: > In D157497#4584621 , @Pivnoy wrote: > >> This discussion was the main motivation for this change. >> https://discourse.llvm.org/t/rfc-refactor-trip

[Lldb-commits] [PATCH] D157497: feat: Migrate isArch16Bit

MaskRay added a comment. In D157497#4584621 , @Pivnoy wrote: > This discussion was the main motivation for this change. > https://discourse.llvm.org/t/rfc-refactor-triple-related-classes/70410/11 > As a result, Triple should become a data class, and its d

[Lldb-commits] [PATCH] D157497: feat: Migrate isArch16Bit

Pivnoy added a comment. This discussion was the main motivation for this change. https://discourse.llvm.org/t/rfc-refactor-triple-related-classes/70410/11 As a result, Triple should become a data class, and its dependencies such as Architecture, Operating System etc. represent in the form of inte

[Lldb-commits] [PATCH] D157497: feat: Migrate isArch16Bit

asb added a comment. Is there some separate discussion thread or proposal about this refactoring and its motivations? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157497/new/ https://reviews.llvm.org/D157497 _