tfiala added a comment.
Sorry, late to the party. All the same, LGTM.
Repository:
rL LLVM
http://reviews.llvm.org/D15715
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL256244: Don't pack the structs of the jit debug interface
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D15715?vs=43444&id=43445#toc
Repository:
rL LLVM
http://reviews.
loladiro accepted this revision.
loladiro added a comment.
This revision is now accepted and ready to land.
Ok, I see. Yes, I agree with this change. LGTM.
http://reviews.llvm.org/D15715
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http
tberghammer added a comment.
I hit the problem when debugging an arm32 target from an x86_64 host and this
CL fixes that issue. It will break if a 32bit target use the same "pragma pack"
attribute I just removed.
The change have no effect for 64bit targets because symfile_size will be 8 byte
a
loladiro added a comment.
I don't think that was part of the code I originally had, but I suppose this
was added for 32bit compatibility? Would this do the right thing with a 32bit
target?
http://reviews.llvm.org/D15715
___
lldb-commits mailing li
tberghammer created this revision.
tberghammer added reviewers: tfiala, endlessroad, loladiro.
tberghammer added a subscriber: lldb-commits.
Don't pack the structs of the jit debug interface
None of the documentation mentions that the entries are packed structs and also
none of the other impleme
