[Lldb-commits] [PATCH] D154505: [lldb][NFC] Remove code duplication in InitOSO

This revision was automatically updated to reflect the committed changes. Closed by commit rG7cea22c0be95: [lldb][NFC] Remove code duplication in InitOSO (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154505/new/ https://revie

[Lldb-commits] [PATCH] D154505: [lldb][NFC] Remove code duplication in InitOSO

fdeazeve updated this revision to Diff 537524. fdeazeve added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154505/new/ https://reviews.llvm.org/D154505 Files: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWAR

[Lldb-commits] [PATCH] D154505: [lldb][NFC] Remove code duplication in InitOSO

fdeazeve added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp:347-348 + uint32_t sibling_idx = so_symbol->GetSiblingIndex(); + // The sibling index can't be less that or equal to the current index + // "i" + if (

[Lldb-commits] [PATCH] D154505: [lldb][NFC] Remove code duplication in InitOSO

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. In D154505#4473986 , @bulbazord wrote: > I'm a big fan of refactoring deeply-nested code to be flatter, so I'm happy > to see this work be

[Lldb-commits] [PATCH] D154505: [lldb][NFC] Remove code duplication in InitOSO

bulbazord added a comment. I'm a big fan of refactoring deeply-nested code to be flatter, so I'm happy to see this work being done! I wasn't aware of `llvm::concat` before, I probably would have used a lambda or something to do this, so it was interesting learning about that. 😄 =

[Lldb-commits] [PATCH] D154505: [lldb][NFC] Remove code duplication in InitOSO

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Two identical loops were iterating over different ranges, leading to code duplication. We replace this by a loop over the