[Lldb-commits] [PATCH] D153900: [lldb] Deprecate SBHostOS threading functionality

bulbazord added a comment. In D153900#4469649 , @mib wrote: > LGTM! @bulbazord when you land this, make sure to close @teemperor's diff > (D104231 ). Thanks! 👍 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D153900: [lldb] Deprecate SBHostOS threading functionality

This revision was automatically updated to reflect the committed changes. Closed by commit rG1c7c9970379e: [lldb] Deprecate SBHostOS threading functionality (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153900/new/ https://r

[Lldb-commits] [PATCH] D153900: [lldb] Deprecate SBHostOS threading functionality

mib added a comment. LGTM! @bulbazord when you land this, make sure to close @teemperor's diff (D104231 ). Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153900/new/ https://reviews.llvm.org/D153900 __

[Lldb-commits] [PATCH] D153900: [lldb] Deprecate SBHostOS threading functionality

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153900/new/ https://reviews.llvm.org/D153900 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D153900: [lldb] Deprecate SBHostOS threading functionality

bulbazord updated this revision to Diff 536864. bulbazord added a comment. Reword deprecation message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153900/new/ https://reviews.llvm.org/D153900 Files: lldb/include/lldb/API/SBHostOS.h lldb/tools

[Lldb-commits] [PATCH] D153900: [lldb] Deprecate SBHostOS threading functionality

JDevlieghere added inline comments. Comment at: lldb/include/lldb/API/SBHostOS.h:28-29 + LLDB_DEPRECATED("Threading functionality in SBHostOS is not well supported " + "and not portable. It is difficult to use from Python. Do " + "not introduce

[Lldb-commits] [PATCH] D153900: [lldb] Deprecate SBHostOS threading functionality

clayborg added a comment. I think the SBHostOS::ThreadCreated() function used to just set the thread name for the current thread, but looks like that hasn't been hooked up for a while. Don't know who was using this before, but LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[Lldb-commits] [PATCH] D153900: [lldb] Deprecate SBHostOS threading functionality

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGMT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153900/new/ https://reviews.llvm.org/D153900 ___

[Lldb-commits] [PATCH] D153900: [lldb] Deprecate SBHostOS threading functionality

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, teemperor, mib, jingham, clayborg. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. For some context, Raphael tried to this befo