[Lldb-commits] [PATCH] D151859: [lldb/Target] Add ability to set name to targets

mib marked 3 inline comments as done. mib added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:546-551 +if (!name.empty()) { + if (name == target_idx_arg) { +target_idx = i; +break; +

[Lldb-commits] [PATCH] D151859: [lldb/Target] Add ability to set name to targets

jingham added a comment. I'd also maybe call this the Target "Label" not the Name. We have a fairly strong use of Name for breakpoint names, and this doesn't have that character at all. Also, if they are Labels, I think it's legit for us to keep them unique, which I think is more sane than tr

[Lldb-commits] [PATCH] D151859: [lldb/Target] Add ability to set name to targets

bulbazord added a comment. In D151859#4385986 , @jingham wrote: > Make sure we do something sensible with "target select " if the user > has given the same name to two targets (or disallow doing that, one or the > other). In addition to this, what happ

[Lldb-commits] [PATCH] D151859: [lldb/Target] Add ability to set name to targets

jingham added a comment. Make sure we do something sensible with "target select " if the user has given the same name to two targets (or disallow doing that, one or the other). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151859/new/ https://revi

[Lldb-commits] [PATCH] D151859: [lldb/Target] Add ability to set name to targets

bulbazord added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:315 + llvm::StringRef name = m_name.GetOptionValue().GetCurrentValueAsRef(); + if (!name.empty()) nit: Comment at: lldb/source/Commands/Comman

[Lldb-commits] [PATCH] D151859: [lldb/Target] Add ability to set name to targets

mib added a comment. I still need to add some tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151859/new/ https://reviews.llvm.org/D151859 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

[Lldb-commits] [PATCH] D151859: [lldb/Target] Add ability to set name to targets

mib created this revision. mib added reviewers: JDevlieghere, bulbazord, jingham. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch add the ability for the user to set a name for a target. This can be