[Lldb-commits] [PATCH] D151765: [lldb] Introduce the FileSpecBuilder abstraction

clayborg added a comment. The idea behind FileSpec containing two ConstStrings, one for the directory and one for he filename is for lookup performance when searching thousands of line tables for a given file and line when setting breakpoints. Currently we pass in a FileSpec + line number and w

[Lldb-commits] [PATCH] D151765: [lldb] Introduce the FileSpecBuilder abstraction

bulbazord planned changes to this revision. bulbazord added a comment. In D151765#4385711 , @jingham wrote: > Why did you choose to have a separate FileSpecBuilder class, rather than > making FileSpec smarter about the structure of the path (e.g. have an

[Lldb-commits] [PATCH] D151765: [lldb] Introduce the FileSpecBuilder abstraction

jingham added a comment. Why did you choose to have a separate FileSpecBuilder class, rather than making FileSpec smarter about the structure of the path (e.g. have an array of StringRef's into the paths for each component.) We could do the parse once the first time a path element was request

[Lldb-commits] [PATCH] D151765: [lldb] Introduce the FileSpecBuilder abstraction

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, jasonmolenda, clayborg. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Mutating a FileSpec is quite expensive. E