[Lldb-commits] [PATCH] D151588: Factor out xcrun (NFC)

bulbazord accepted this revision. bulbazord added a comment. Sounds good CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151588/new/ https://reviews.llvm.org/D151588 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [PATCH] D151588: Factor out xcrun (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151588/new/ https://reviews.llvm.org/D151588 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D151588: Factor out xcrun (NFC)

aprantl added a comment. In D151588#4377128 , @bulbazord wrote: > What is the motivation behind this change? > > Also, why did you factor out `--show-sdk-path` into an argument? I assume you > want to use `xcrun` for other purposes? This is in preparati

[Lldb-commits] [PATCH] D151588: Factor out xcrun (NFC)

aprantl updated this revision to Diff 526194. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151588/new/ https://reviews.llvm.org/D151588 Files: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm Index: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm

[Lldb-commits] [PATCH] D151588: Factor out xcrun (NFC)

bulbazord added a comment. What is the motivation behind this change? Also, why did you factor out `--show-sdk-path` into an argument? I assume you want to use `xcrun` for other purposes? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151588/new/ https://reviews.llvm.org/D151588 _

[Lldb-commits] [PATCH] D151588: Factor out xcrun (NFC)

aprantl created this revision. aprantl added reviewers: JDevlieghere, bulbazord. Herald added a project: All. aprantl requested review of this revision. https://reviews.llvm.org/D151588 Files: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm Index: lldb/source/Host/macosx/objcxx/HostInfoMacOSX