[Lldb-commits] [PATCH] D149625: [lldb] Refactor SBFileSpec::GetDirectory

bulbazord added a comment. Ok, after looking at this more closely, it's a little clearer to me why `SBFileSpec::GetDirectory` was written this way to begin with. The method itself requires its return value to be denormalized (something not explicitly documented in the header nor the SWIG docstr

[Lldb-commits] [PATCH] D149625: [lldb] Refactor SBFileSpec::GetDirectory

bulbazord added a comment. > AssertionError: > 'C:\\Users\\tcwg\\llvm-worker\\lldb-aarch64-windows\\build\\lldb-test-build.noindex\\functionalities\\process_save_core\\TestProcessSaveCore.test_save_windows_mini_dump_dwarf\\a.out' > not found in > ['C:/Users/tcwg/llvm-worker/lldb-aarch64-windows

[Lldb-commits] [PATCH] D149625: [lldb] Refactor SBFileSpec::GetDirectory

This revision was automatically updated to reflect the committed changes. Closed by commit rG58e6caaba1cf: Revert "[lldb] Refactor SBFileSpec::GetDirectory" (authored by omjavaid). Changed prior to commit: https://reviews.llvm.org/D149625?vs=518782&id=522285#toc Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D149625: [lldb] Refactor SBFileSpec::GetDirectory

omjavaid reopened this revision. omjavaid added a comment. This revision is now accepted and ready to land. This introduced test failures on windows lldb-aarch64-windows buildbot. lldb-api :: functionalities/process_save_core/TestProcessSaveCore.py lldb-api :: python_api/symbol-context/TestSy

[Lldb-commits] [PATCH] D149625: [lldb] Refactor SBFileSpec::GetDirectory

bulbazord added a comment. In D149625#4312838 , @jingham wrote: > The old code had the side-effect of NOT resolving the path of the SBFileSpec > in order to get its directory. I am not sure whether that was on purpose or > not, however. To be more pre

[Lldb-commits] [PATCH] D149625: [lldb] Refactor SBFileSpec::GetDirectory

jingham added a comment. The old code had the side-effect of NOT resolving the path of the SBFileSpec in order to get its directory. I am not sure whether that was on purpose or not, however. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149625/n

[Lldb-commits] [PATCH] D149625: [lldb] Refactor SBFileSpec::GetDirectory

This revision was automatically updated to reflect the committed changes. Closed by commit rG2bea2d7b070d: [lldb] Refactor SBFileSpec::GetDirectory (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149625/new/ https://reviews.ll

[Lldb-commits] [PATCH] D149625: [lldb] Refactor SBFileSpec::GetDirectory

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. There's no reason to create an entire new filespec to mutate and