[Lldb-commits] [PATCH] D149567: [lldb] Group debugger properties (NFC)

2023-04-30 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 518385. JDevlieghere edited the summary of this revision. JDevlieghere added a comment. Use one big Doxygen group for all the properties to make this less noisy. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149567/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D149567: [lldb] Group debugger properties (NFC)

2023-04-30 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In D149567#4309195 , @mib wrote: > nit: Sometimes we have newlines between methods and sometimes we don't ... It > would be nice to be consistent, otherwise LGTM Methods relating to the same property are grouped together (i

[Lldb-commits] [PATCH] D149567: [lldb] Group debugger properties (NFC)

2023-04-30 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib added a comment. nit: Sometimes we have newlines between methods and sometimes we don't ... It would be nice to be consistent, otherwise LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149567/new/ https://reviews.llvm.org/D149567 ___

[Lldb-commits] [PATCH] D149567: [lldb] Group debugger properties (NFC)

2023-04-30 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: mib, bulbazord. Herald added a project: All. JDevlieghere requested review of this revision. Group debugger properties in Doxygen groups. https://reviews.llvm.org/D149567 Files: lldb/include/lldb/Core/Debugger.h Index: lldb/in