[Lldb-commits] [PATCH] D149379: [lldb] Add tests for command removal

2023-05-15 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. In D149379#4331059 , @wallace wrote: > The alias still works because it still holds a reference to it. I could add > that as a test The alias works but the original command is gone? Interesting. We should definitely test that

[Lldb-commits] [PATCH] D149379: [lldb] Add tests for command removal

2023-05-09 Thread walter erquinigo via Phabricator via lldb-commits
wallace added a comment. The alias still works because it still holds a reference to it. I could add that as a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149379/new/ https://reviews.llvm.org/D149379 ___

[Lldb-commits] [PATCH] D149379: [lldb] Add tests for command removal

2023-05-09 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. What happens if you remove a command that had an alias bound to it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149379/new/ https://reviews.llvm.org/D149379 ___ lldb-commits ma

[Lldb-commits] [PATCH] D149379: [lldb] Add tests for command removal

2023-04-27 Thread walter erquinigo via Phabricator via lldb-commits
wallace created this revision. wallace added a reviewer: jingham. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds some tests for removing lldb commands, user command and aliases. I've done in