[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

kuilpd updated this revision to Diff 514435. kuilpd added a comment. Fixed Triple.h include. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146965/new/ https://reviews.llvm.org/D146965 Files: lldb/include/lldb/Utility/ArchSpec.h lldb/include/lldb/Utility/DataExtractor.h lldb/sourc

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

asl added a comment. @kuilpd Please ensure that the patch is rebased into top of `main` and builds w/o errors / warnings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146965/new/ https://reviews.llvm.org/D146965

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

This revision was automatically updated to reflect the committed changes. Closed by commit rG82c02b733c77: [lldb] Add support for MSP430 in LLDB. (authored by asl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146965/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

asl added a comment. Thanks @bulbazord @DavidSpickett ! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146965/new/ https://reviews.llvm.org/D146965 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

bulbazord accepted this revision. bulbazord added a comment. In D146965#4274274 , @DavidSpickett wrote: > I'm sure there's something missing but LGTM. > > @bulbazord ? I'm satisfied with this since there are tests. I'm not sure what might be missing bu

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. I'm sure there's something missing but LGTM. @bulbazord ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146965/new/ https://reviews.llvm.org/D146965 __

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

kuilpd updated this revision to Diff 513245. kuilpd added a comment. Rebased and updated register info initialization. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146965/new/ https://reviews.llvm.org/D146965 Files: lldb/include/lldb/Utility/ArchSpec.h lldb/include/lldb/Utility/Da

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

DavidSpickett added a comment. I just landed https://github.com/llvm/llvm-project/commit/57c8fee1b97eb7e70513b935b765f8381a941b18 which will give you build errors. All you have to do is add an extra `nullptr` to your register infos. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146965

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

DavidSpickett added a comment. Also please update the commit message to make it clear that this is for using lldb with mspdebug, not with lldb-server. To help us and also to help anyone who might link to this commit to share the good news :) CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

DavidSpickett added a comment. Thanks for the test changes, looks good. There is some documentation that lists what targets we support, MSP430 should be added there. `lldb/docs/index.rst` is one of those. Otherwise, can anyone else think of major debug features that should be (at least) smoke

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

kuilpd updated this revision to Diff 512891. kuilpd marked 6 inline comments as done. kuilpd added a comment. Added comments, changed memory strings formatting, added disassembler check. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146965/new/ https://reviews.llvm.org/D146965 Files:

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

DavidSpickett added a comment. > Looked into core dumping in LLDB a bit, I think it pretty much requires that > there is an OS, and there needs to be an explicit support for the > architecture in question. Plus, mspdebug doesn't actually support core files, > there is no use for it now even if

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

kuilpd added a comment. In D146965#4240075 , @DavidSpickett wrote: > Two things come to mind: > > - Core files (though it is embedded so is that even a thing?) Looked into core dumping in LLDB a bit, I think it pretty much requires that there is an OS,

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

kuilpd updated this revision to Diff 511497. kuilpd added a comment. Added a test for registers, breakpoints, stepping, backtracing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146965/new/ https://reviews.llvm.org/D146965 Files: lldb/include/lldb/Utility/ArchSpec.h lldb/include/l

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

bulbazord added inline comments. Comment at: lldb/source/Plugins/Platform/Linux/PlatformLinux.cpp:127 llvm::Triple::hexagon, llvm::Triple::mips, llvm::Triple::mips64el, - llvm::Triple::mipsel, llvm::Triple::systemz}, + llvm::Triple::mipsel, llvm::Triple:

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

DavidSpickett added a comment. > It is completely bare metal, but the address space is only 16-bit, so would > the entire 64 KB of memory count as a core dump? It's more "world" than "core" but yeah why not. Probably won't need all 64k though, see below... > I can make a test that checks if fa

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

kuilpd added a comment. In D146965#4240075 , @DavidSpickett wrote: > Two things come to mind: > > - Core files (though it is embedded so is that even a thing?) It is completely bare metal, but the address space is only 16-bit, so would the entire 64 KB

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

DavidSpickett added a comment. > One concern I have is that there are no tests. I can understand that it may > be difficult to get automated tests running testing the debugging of an > architecture like MSP430 but there are things we can test to sanity test > MSP430 support Two things come to

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

kuilpd updated this revision to Diff 509089. kuilpd added a comment. Wrong previous diff. Added asserts in default cases, added checks for architecture instead of address size, added a unit test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146965/new/ https://reviews.llvm.org/D14696

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

kuilpd updated this revision to Diff 509080. kuilpd added a comment. Added asserts in default cases, added checks for architecture instead of address size, added a unit test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146965/new/ https://reviews.llvm.org/D146965 Files: lldb/inclu

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

kuilpd marked 8 inline comments as done. kuilpd added inline comments. Comment at: lldb/source/Expression/IRMemoryMap.cpp:113-114 lldbassert(process_sp->GetAddressByteSize() == 4 || end_of_memory != 0xull); bulbazord wrote: > I th

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

bulbazord added a comment. I'm not too familiar with MSP430 but the general idea looks fine. Others may have comments about areas I'm less familiar with. One concern I have is that there are no tests. I can understand that it may be difficult to get automated tests running testing the debugging

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

asl added a comment. @JDevlieghere @bulbazord I don't think I know lldb codebase well enough to cover the complete review here. But from MSP430-standpoint things seem to be correct. Will you be able to review or suggest some other reviewers? Thanks! Repository: rG LLVM Github Monorepo CHAN

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

kuilpd created this revision. kuilpd added a reviewer: asl. kuilpd added a project: LLDB. Herald added subscribers: Michael137, JDevlieghere. Herald added a project: All. kuilpd requested review of this revision. Herald added a subscriber: lldb-commits. Add MSP430 to the list of available targets,